From: "Kristian Høgsberg" <krh@redhat.com>
To: Olaf Hering <olh@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux1394-devel <linux1394-devel@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] New firewire stack
Date: Wed, 02 May 2007 15:53:08 -0400 [thread overview]
Message-ID: <4638EC24.2020703@redhat.com> (raw)
In-Reply-To: <20070502122147.GA31215@suse.de>
Olaf Hering wrote:
> On Tue, May 01, Kristian Høgsberg wrote:
>
>> drivers/firewire/Kconfig | 60 ++
>
> NACK.
> Upgrade the current drivers/ieee1394/ with the new code, and keep all
> existing module names.
What's your reasoning here? Having different module names allows people to
compile both stacks and switch between them as they wish.
Another point in favour of different module names is that the new stack
doesn't actually provide the same user space interfaces as the old stack.
Basically, no applications use the raw kernel interfaces and the new stack is
only compatible at the library level. In the light of this, I think it's fair
to change the module names.
As for putting the new stack in drivers/ieee1394 - I don't know, I think it
makes sense to keep the new stack in it's own directory. If it's a deal
breaker for inclusion, let's talk about moving it, but it would be nice if you
could elaborate just a little bit beyond "NACK".
thanks,
Kristian
next prev parent reply other threads:[~2007-05-02 19:54 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 20:27 [git pull] New firewire stack Kristian Høgsberg
2007-05-01 21:34 ` Stefan Richter
2007-05-02 9:00 ` Christoph Hellwig
2007-05-02 12:13 ` Stefan Richter
2007-05-02 12:15 ` [PATCH 1/6] firewire: handling of cards, buses, nodes Stefan Richter
2007-05-02 12:16 ` [PATCH 2/6] firewire: isochronous and asynchronous I/O Stefan Richter
2007-05-02 12:17 ` [PATCH 3/6] firewire: char device interface Stefan Richter
2007-05-02 12:18 ` [PATCH 4/6] firewire: OHCI-1394 lowlevel driver Stefan Richter
2007-05-02 12:18 ` [PATCH 5/6] firewire: SBP-2 highlevel driver Stefan Richter
2007-05-02 12:19 ` [PATCH 6/6] firewire: add it all to kbuild Stefan Richter
2007-05-02 18:05 ` Stefan Richter
2007-05-02 19:44 ` Christoph Hellwig
2007-05-02 23:01 ` Stefan Richter
2007-05-03 4:15 ` Sam Ravnborg
2007-05-03 8:10 ` Christoph Hellwig
2007-05-08 0:14 ` Kristian Høgsberg
2007-05-02 19:44 ` [PATCH 5/6] firewire: SBP-2 highlevel driver Christoph Hellwig
2007-05-02 21:53 ` Stefan Richter
2007-05-02 22:10 ` Stefan Richter
2007-05-04 9:53 ` Christoph Hellwig
2007-05-04 11:20 ` Stefan Richter
2007-05-09 21:05 ` Kristian Høgsberg
2007-05-09 21:48 ` Stefan Richter
2007-05-09 21:57 ` Stefan Richter
2007-05-09 22:13 ` Kristian Høgsberg
2007-05-09 22:56 ` Stefan Richter
2007-05-04 11:11 ` [PATCH 4/6] firewire: OHCI-1394 lowlevel driver Christoph Hellwig
2007-05-09 23:40 ` Kristian Høgsberg
2007-05-02 15:35 ` [PATCH 3/6] firewire: char device interface John Stoffel
2007-05-02 16:06 ` Stefan Richter
2007-05-02 21:11 ` Kristian Høgsberg
2007-05-04 9:48 ` Christoph Hellwig
2007-05-08 0:19 ` Kristian Høgsberg
2007-05-02 19:30 ` Christoph Hellwig
2007-05-08 0:08 ` Kristian Høgsberg
2007-05-02 19:29 ` [PATCH 2/6] firewire: isochronous and asynchronous I/O Christoph Hellwig
2007-05-03 0:08 ` Kristian Høgsberg
2007-05-03 8:54 ` Stefan Richter
2007-05-02 15:55 ` [PATCH 1/6] firewire: handling of cards, buses, nodes Pekka Enberg
2007-05-02 19:16 ` Stefan Richter
2007-05-02 20:35 ` Pekka Enberg
2007-05-07 22:02 ` Kristian Høgsberg
2007-05-02 21:16 ` Kristian Høgsberg
2007-05-02 19:22 ` Christoph Hellwig
2007-05-07 23:42 ` Kristian Høgsberg
2007-05-02 20:00 ` [git pull] New firewire stack Kristian Høgsberg
2007-05-02 12:21 ` Olaf Hering
2007-05-02 12:48 ` Stefan Richter
2007-05-02 13:56 ` Gene Heskett
2007-05-02 18:51 ` Stefan Richter
2007-05-02 15:27 ` Adrian Bunk
2007-05-02 20:03 ` Kristian Høgsberg
2007-05-02 19:53 ` Kristian Høgsberg [this message]
2007-05-02 20:03 ` Olaf Hering
2007-05-10 17:26 ` [git pull] New firewire stack (updated) Stefan Richter
2007-05-10 17:38 ` Christoph Hellwig
2007-05-10 17:51 ` Adrian Bunk
2007-05-10 17:56 ` Stefan Richter
2007-05-10 18:05 ` Stefan Richter
[not found] <mailman.197656.1178135675.32383.linux1394-devel@lists.sourceforge.net>
2007-05-03 0:04 ` [git pull] New firewire stack Jonathan Woithe
2007-05-03 8:22 ` Stefan Richter
2007-05-03 11:48 ` Olaf Hering
2007-05-03 13:30 ` Stefan Richter
2007-05-03 16:34 ` Adrian Bunk
2007-05-03 17:33 ` Kristian Høgsberg
2007-05-04 5:54 ` Bill Fink
2007-05-05 21:17 ` Olaf Hering
2007-05-08 0:28 ` Kristian Høgsberg
2007-05-03 23:07 ` Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4638EC24.2020703@redhat.com \
--to=krh@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=olh@suse.de \
--cc=stefanr@s5r6.in-berlin.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox