public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chuck Ebbert <cebbert@redhat.com>
To: Zachary Amsden <zach@vmware.com>
Cc: Marcos Pinto <markybob@gmail.com>, Andi Kleen <ak@suse.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: Mysterious RTC hangs on x86_64 - fixed, sort of
Date: Wed, 02 May 2007 18:56:22 -0400	[thread overview]
Message-ID: <46391716.9040001@redhat.com> (raw)
In-Reply-To: <46391253.30201@vmware.com>

Zachary Amsden wrote:
> With this patch, /sbin/hwclock no longer hangs my AMD64 machine when run
> after reaching multiuser.  What I don't understand is why.  I have the
> RTC based sound sequencer timer as a module, but not loaded, and the
> error message I added to indicate broken rtc control does not fire.
> 
> So why is it that if I stop taking the rtc_task_lock and issuing the
> callbacks which should never be held or exist that my system no longer
> hard freezes?
> 
> --- /tmp/a      2007-05-03 15:36:07.451256181 -0700
> +++ drivers/char/rtc.c  2007-05-03 15:27:49.000000000 -0700
> @@ -265,10 +265,10 @@
>         spin_unlock (&rtc_lock);
>  
>         /* Now do the rest of the actions */
> -       spin_lock(&rtc_task_lock);
> -       if (rtc_callback)
> -               rtc_callback->func(rtc_callback->private_data);
> -       spin_unlock(&rtc_task_lock);
> +/*     spin_lock(&rtc_task_lock); */
> +//     if (rtc_callback)
> +//             rtc_callback->func(rtc_callback->private_data);
> +/*     spin_unlock(&rtc_task_lock); */
>         wake_up_interruptible(&rtc_wait);       

Try leaving the spinlocks and just disabling the callbacks. And maybe
enable spinlock debugging...

> 
> CONFIG_HPET_EMULATE_RTC=y

Did you try without that?


  reply	other threads:[~2007-05-02 22:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-02 22:36 Mysterious RTC hangs on x86_64 - fixed, sort of Zachary Amsden
2007-05-02 22:56 ` Chuck Ebbert [this message]
2007-05-03  0:05   ` Zachary Amsden
2007-05-03  4:23   ` Zachary Amsden
2007-05-03  9:00     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46391716.9040001@redhat.com \
    --to=cebbert@redhat.com \
    --cc=a.zummo@towertech.it \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markybob@gmail.com \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox