From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v2 1/1] Misc: add sensable phantom driver
Date: Thu, 03 May 2007 16:41:53 +0200 [thread overview]
Message-ID: <4639F4B1.2080606@gmail.com> (raw)
In-Reply-To: <20070502234956.cdfe31c2.akpm@linux-foundation.org>
Andrew Morton napsal(a):
>> +static int phantom_ioctl(struct inode *inode, struct file *file, u_int cmd,
>> + u_long arg)
>
> Could we please use standard-looking types in this driver? u32 and u64 and
> things?
>
> However in this case, as it's an ioctl handler it should be "int" and
> "unsigned long".
actually, according to file_operations struct:
int (*ioctl) (struct inode *, struct file *, unsigned int, unsigned long);
"*unsigned* int" and "unsigned long" are correct types...
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
prev parent reply other threads:[~2007-05-03 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 15:56 [PATCH -v2 1/1] Misc: add sensable phantom driver Jiri Slaby
2007-05-03 6:49 ` Andrew Morton
2007-05-03 12:40 ` Jiri Slaby
2007-05-03 17:36 ` Andrew Morton
2007-05-03 14:41 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4639F4B1.2080606@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox