[patch] export hrtimer_forward

[patch] export hrtimer_forward

[Stas Sergeev]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

Hello.

It seems hrtimer_forward was forgotten to
export - other symbols of the hrtimers API
are already exported.
Unless I am missing something, using the
hrtimers without that function is problematic.

Andrew, could you please apply?

Signed-off-by: <stsp@aknet.ru>


[-- Attachment #2: exp_hrfwd.diff --]
[-- Type: text/x-patch, Size: 262 bytes --]

--- a/kernel/hrtimer.c	2007-04-27 13:00:25.000000000 +0400
+++ b/kernel/hrtimer.c	2007-05-03 17:27:40.000000000 +0400
@@ -666,6 +666,7 @@
 
 	return orun;
 }
+EXPORT_SYMBOL_GPL(hrtimer_forward);
 
 /*
  * enqueue_hrtimer - internal function to (re)start a timer

Re: [patch] export hrtimer_forward

[Peter Zijlstra]

On Thu, 2007-05-03 at 21:57 +0400, Stas Sergeev wrote:
> Hello.
> 
> It seems hrtimer_forward was forgotten to
> export - other symbols of the hrtimers API
> are already exported.
> Unless I am missing something, using the
> hrtimers without that function is problematic.
> 
> Andrew, could you please apply?

Are there actual in-tree users of this symbol? Without we usually leave
the symbol unexported, this saves some space.

Re: [patch] export hrtimer_forward

[Stas Sergeev]

Hello.

Peter Zijlstra wrote:
>> It seems hrtimer_forward was forgotten to
>> export - other symbols of the hrtimers API
> Are there actual in-tree users of this symbol? Without we usually leave
> the symbol unexported, this saves some space.
Do you mean it was really left intentional?
Unbeleivable! But why the other parts of a
hrtimer API are exported nevertheless, and
only this particular function not?

As for the users - I am porting my pcsp driver to
it and I need that function.
It is not exactly in-tree stuff, but it was
in an ALSA tree for years already, so it is a
close one.

Re: [patch] export hrtimer_forward

[Andrew Morton]

On Thu, 03 May 2007 23:10:02 +0400
Stas Sergeev <stsp@aknet.ru> wrote:

> Hello.
> 
> Peter Zijlstra wrote:
> >> It seems hrtimer_forward was forgotten to
> >> export - other symbols of the hrtimers API
> > Are there actual in-tree users of this symbol? Without we usually leave
> > the symbol unexported, this saves some space.
> Do you mean it was really left intentional?
> Unbeleivable! But why the other parts of a
> hrtimer API are exported nevertheless, and
> only this particular function not?

It was probably an oversight - generally we take the position that all the
formal interface of a subsystem is exported to modules rather than a
piecemeal whichever-bits-kernel.org-happens-to-use-today approach.

Thomas, is hrtimer_forward() considered part of the hrtimer public API? 
And are you OK with the patch?


> As for the users - I am porting my pcsp driver to
> it and I need that function.
> It is not exactly in-tree stuff, but it was
> in an ALSA tree for years already, so it is a
> close one.

Re: [patch] export hrtimer_forward

[Thomas Gleixner]

On Thu, 2007-05-03 at 16:58 -0700, Andrew Morton wrote:
> It was probably an oversight - generally we take the position that all the
> formal interface of a subsystem is exported to modules rather than a
> piecemeal whichever-bits-kernel.org-happens-to-use-today approach.
> 
> Thomas, is hrtimer_forward() considered part of the hrtimer public API? 
> And are you OK with the patch?

Yes to both.

	tglx