From: Steven Rostedt <srostedt@redhat.com>
To: Daniel Walker <dwalker@mvista.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -rt] wrong usage of smp_processor_id()
Date: Thu, 03 May 2007 16:12:12 -0400 [thread overview]
Message-ID: <463A421C.4080507@redhat.com> (raw)
In-Reply-To: <20070503200822.696754319@mvista.com>
Daniel Walker wrote:
> ---
> kernel/latency_trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.21/kernel/latency_trace.c
> ===================================================================
> --- linux-2.6.21.orig/kernel/latency_trace.c
> +++ linux-2.6.21/kernel/latency_trace.c
> @@ -105,7 +105,7 @@ static inline int DEBUG_WARN_ON(int cond
> #ifdef CONFIG_CRITICAL_IRQSOFF_TIMING
> # ifdef CONFIG_CRITICAL_PREEMPT_TIMING
> static DEFINE_PER_CPU(int, trace_cpu_idle);
> -# define irqs_off_preempt_count() (!__get_cpu_var(trace_cpu_idle) && preempt_count())
> +# define irqs_off_preempt_count() (preempt_count() && !__get_cpu_var(trace_cpu_idle))
> # else
> # define irqs_off_preempt_count() 0
> # endif
Ingo,
This is on top of one of my patches that I sent you (the cpu idle one).
So it's not for the 2.6.21-rt1, but if you apply my patch, this needs to
be added too.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2007-05-03 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 20:08 [PATCH -rt] wrong usage of smp_processor_id() Daniel Walker
2007-05-03 20:12 ` Steven Rostedt [this message]
2007-05-03 20:21 ` Daniel Walker
2007-05-03 20:31 ` Steven Rostedt
2007-05-03 20:33 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463A421C.4080507@redhat.com \
--to=srostedt@redhat.com \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox