Re: [RFC] [PATCH] DRM TTM Memory Manager patch

Greg KH
2007-05-02T04:21:00Z

On Wed, May 02, 2007 at 12:36:36AM +0200, Ingo Oeser wrote:
> On Tuesday 01 May 2007, Dave Airlie wrote:
> > > - what's with the /proc interface? Don't add new proc code for
> > > non-process related things. This should all go into sysfs
> > > somewhere. And yes, I know /proc/dri/ is there today, but don't add
> > > new stuff please.
> >
> > Well we should move all that stuff to sysfs, but we have all the
> > infrastructure for publishing this stuff under /proc/dri and adding
> > new files doesn't take a major amount, as much as I appreciate sysfs,
> > it isn't suitable for this sort of information dump, the whole one
> > value per file is quite useless to provide this sort of information
> > which is uni-directional for users to send to us for debugging without
> > have to install some special tool to join all the values into one
> > place.. and I don't think drmfs is the answer either... or maybe it
> > is....
>
> Ok, what about debugfs then? If it is just for debugging blobs -> debugfs,
> if it is crucial for operation -> sysfs and representation of one value
> per file.

You beat me too it :)

Yes, this is _exactly_ what debugfs is for, in fact, it will probably
make your code a bit smaller to use it instead of /proc.

thanks,

greg k-h