From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755409AbXEDPAA (ORCPT ); Fri, 4 May 2007 11:00:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755419AbXEDPAA (ORCPT ); Fri, 4 May 2007 11:00:00 -0400 Received: from gw.goop.org ([64.81.55.164]:49736 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755409AbXEDO7w (ORCPT ); Fri, 4 May 2007 10:59:52 -0400 Message-ID: <463B4A69.6020203@goop.org> Date: Fri, 04 May 2007 07:59:53 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Rusty Russell , Andi Kleen , Chris Wright , Zachary Amsden , Andrew Morton , Linus Torvalds , "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization" References: <1178280770.23670.61.camel@localhost.localdomain> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > It's not theatrical. It makes this code path extremely brittle and > very hard to change, which over the long term means that it is > impossible to maintain. Quickly resulting in a state where any little > change will break something. Removing the code now is premature. I'm presuming you're proposing this as a .23 change, since we're planning on changing the paravirt boot to make use of bzImage and the boot protocol then anyway. The world isn't going to fall apart if its in there for a couple of months. J