From: "H. Peter Anvin" <hpa@zytor.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Andi Kleen <ak@suse.de>, Chris Wright <chrisw@sous-sol.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Zachary Amsden <zach@vmware.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/3] boot bzImages under paravirt
Date: Fri, 04 May 2007 08:49:10 -0700 [thread overview]
Message-ID: <463B55F6.5030306@zytor.com> (raw)
In-Reply-To: <1178290502.23670.111.camel@localhost.localdomain>
Rusty Russell wrote:
>
> It was a PITA because we can't just load $0x18 into %ss: it has to be
> $0x19. I started doing it (read %cs, mask off bottom 2 bits, orl
> __BOOT_DS), but between that extra code and the extra code to then
> change segments back... well, we have to skip the cli anyway so it was
> easy to skip them all.
>
> I think Jeremy said Xen doesn't start on the boot descriptors either. I
> have to wonder why we don't just run on the boot descriptors forever
> (#define __KERNEL_DS __BOOT_DS etc)?
>
You can't do that once you define your own layout, or you introduce a
nasty intermodule dependency which shouldn't exist.
The rule should be:
- You MUST NOT reload segments before LGDT.
(One can possibly get away with declaring that DS = CS+8 by
protocol and load dynamic values, but that's not a good thing.)
- After LGDT, you MUST load your own segment values.
Anything else is just broken.
-hpa
next prev parent reply other threads:[~2007-05-04 15:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 12:59 [RFC PATCH 1/3] Replace paravirt_probe with "platform type" boot header field Rusty Russell
2007-05-04 13:02 ` [RFC PATCH 2/3] lguest: Boot with virtual == physical to get closer to native Linux Rusty Russell
2007-05-04 13:07 ` [RFC PATCH 3/3] boot bzImages under paravirt Rusty Russell
2007-05-04 14:38 ` Eric W. Biederman
2007-05-04 14:55 ` Rusty Russell
2007-05-04 15:49 ` H. Peter Anvin [this message]
2007-05-04 15:15 ` Jeremy Fitzhardinge
2007-05-04 15:45 ` H. Peter Anvin
2007-05-04 16:13 ` Jeremy Fitzhardinge
2007-05-04 16:43 ` H. Peter Anvin
2007-05-04 16:57 ` Eric W. Biederman
2007-05-04 17:07 ` H. Peter Anvin
2007-05-04 17:30 ` Eric W. Biederman
2007-05-04 18:22 ` Jeremy Fitzhardinge
2007-05-04 18:48 ` Eric W. Biederman
2007-05-04 18:55 ` Jeremy Fitzhardinge
2007-05-04 19:21 ` Eric W. Biederman
2007-05-04 16:46 ` Eric W. Biederman
2007-05-04 17:25 ` Jeremy Fitzhardinge
2007-05-04 17:27 ` H. Peter Anvin
2007-05-04 17:36 ` Eric W. Biederman
2007-05-04 17:44 ` H. Peter Anvin
2007-05-04 18:25 ` Jeremy Fitzhardinge
2007-05-04 14:01 ` [RFC PATCH 1/3] Replace paravirt_probe with "platform type" boot header field Eric W. Biederman
2007-05-04 14:18 ` Rusty Russell
2007-05-04 14:23 ` Eric W. Biederman
2007-05-04 15:52 ` H. Peter Anvin
2007-05-04 16:48 ` Eric W. Biederman
2007-05-04 17:13 ` H. Peter Anvin
2007-05-04 18:30 ` Eric W. Biederman
2007-05-04 18:55 ` H. Peter Anvin
2007-05-04 19:10 ` Eric W. Biederman
2007-05-04 19:14 ` H. Peter Anvin
2007-05-04 19:31 ` Eric W. Biederman
2007-05-04 19:19 ` H. Peter Anvin
2007-05-04 15:10 ` Eric W. Biederman
2007-05-04 15:53 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463B55F6.5030306@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=ebiederm@xmission.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).