Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

Roman Zippel
2007-05-07T13:46:16Z

Hi,

On Mon, 7 May 2007, Jeff Garzik wrote:

> > select seriously screws with the dependencies, it's especially problematic
> > if the selected symbol has other dependencies as HDLC in this case, it makes
> > it only more complicated to get the dependencies correct again.
> > Please use it only if it solves a real problem.
>
> What he's doing is the standard way to deal with library-style code. Nothing
> wrong with the patch, it's continuing established methods.

select was never meant as autoconfiguration tool. It can't be said often
enough: select seriously screws with the dependencies, _please_ don't use
it as a simple depends replacement.
HDLC doesn't really look like simple library code, what's up with all the
HDLC_* options?

bye, Roman