From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB48C3A5A1 for ; Mon, 19 Aug 2019 13:07:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B516220843 for ; Mon, 19 Aug 2019 13:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727674AbfHSNHl (ORCPT ); Mon, 19 Aug 2019 09:07:41 -0400 Received: from mga04.intel.com ([192.55.52.120]:56483 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfHSNHl (ORCPT ); Mon, 19 Aug 2019 09:07:41 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 06:07:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,403,1559545200"; d="scan'208";a="168744924" Received: from ddalessa-mobl.amr.corp.intel.com (HELO [10.254.207.195]) ([10.254.207.195]) by orsmga007.jf.intel.com with ESMTP; 19 Aug 2019 06:07:38 -0700 Subject: Re: [PATCH] infiniband: hfi1: fix a memory leak bug To: Wenwen Wang Cc: Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , "open list:HFI1 DRIVER" , open list References: <1566156571-4335-1-git-send-email-wenwen@cs.uga.edu> From: Dennis Dalessandro Message-ID: <463bb1cb-d132-2f5f-6e94-e0115228c3cb@intel.com> Date: Mon, 19 Aug 2019 09:07:38 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1566156571-4335-1-git-send-email-wenwen@cs.uga.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/2019 3:29 PM, Wenwen Wang wrote: > In fault_opcodes_read(), 'data' is not deallocated if debugfs_file_get() > fails, leading to a memory leak. To fix this bug, introduce the 'free_data' > label to free 'data' before returning the error. > > Signed-off-by: Wenwen Wang Acked-by: Dennis Dalessandro