From: Guillaume Chazarain <guichaz@yahoo.fr>
To: akpm@linux-foundation.org
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 010/455] block_write_full_page(): report ENOSPC
Date: Tue, 08 May 2007 13:57:09 +0200 [thread overview]
Message-ID: <46406595.2000205@yahoo.fr> (raw)
In-Reply-To: <200705080723.l487NR1v016370@shell0.pdx.osdl.net>
akpm@linux-foundation.org a écrit :
> block_write_full_page() forgot to propagate ENPSOC into the address_space.
> --- a/fs/buffer.c~block_write_full_page-handle-enospc
> +++ a/fs/buffer.c
> @@ -1727,6 +1727,7 @@ recover:
> } while ((bh = bh->b_this_page) != head);
> SetPageError(page);
> BUG_ON(PageWriteback(page));
> + mapping_set_error(page->mapping, err);
> set_page_writeback(page);
> do {
> struct buffer_head *next = bh->b_this_page;
As I said in http://lkml.org/lkml/2007/2/9/336 I am not aware of any
call stack where the error is dropped here.
So, this patch should not harm but I am not sure it does any good.
Thanks.
--
Guillaume
parent reply other threads:[~2007-05-08 11:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200705080723.l487NR1v016370@shell0.pdx.osdl.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46406595.2000205@yahoo.fr \
--to=guichaz@yahoo.fr \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox