* Re: [patch 010/455] block_write_full_page(): report ENOSPC
[not found] <200705080723.l487NR1v016370@shell0.pdx.osdl.net>
@ 2007-05-08 11:57 ` Guillaume Chazarain
0 siblings, 0 replies; only message in thread
From: Guillaume Chazarain @ 2007-05-08 11:57 UTC (permalink / raw)
To: akpm; +Cc: torvalds, linux-kernel
akpm@linux-foundation.org a écrit :
> block_write_full_page() forgot to propagate ENPSOC into the address_space.
> --- a/fs/buffer.c~block_write_full_page-handle-enospc
> +++ a/fs/buffer.c
> @@ -1727,6 +1727,7 @@ recover:
> } while ((bh = bh->b_this_page) != head);
> SetPageError(page);
> BUG_ON(PageWriteback(page));
> + mapping_set_error(page->mapping, err);
> set_page_writeback(page);
> do {
> struct buffer_head *next = bh->b_this_page;
As I said in http://lkml.org/lkml/2007/2/9/336 I am not aware of any
call stack where the error is dropped here.
So, this patch should not harm but I am not sure it does any good.
Thanks.
--
Guillaume
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-05-08 11:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200705080723.l487NR1v016370@shell0.pdx.osdl.net>
2007-05-08 11:57 ` [patch 010/455] block_write_full_page(): report ENOSPC Guillaume Chazarain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox