From: Prarit Bhargava <prarit@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
Andi Kleen <andi@basil.nowhere.org>
Subject: Re: Please revert 86c0baf123e474b6eb404798926ecf62b426bf3a
Date: Tue, 08 May 2007 10:07:32 -0400 [thread overview]
Message-ID: <46408424.6050301@redhat.com> (raw)
In-Reply-To: <20070508134928.GA13212@flint.arm.linux.org.uk>
Russell King wrote:
> The change:
>
> +#ifdef CONFIG_HOTPLUG_CPU
> +#define __INIT .section ".text","ax"
> +#define __INITDATA .section ".data","aw"
> +#else
> #define __INIT .section ".init.text","ax"
> -#define __FINIT .previous
> #define __INITDATA .section ".init.data","aw"
> +#endif
> +#define __FINIT .previous
>
>
Something is not right here.... was this the patch that I submitted? If
so then I definitely screwed up pretty badly.
I thought I had done (sorry for the cut-and-paste):
+#ifdef CONFIG_HOTPLUG_CPU
+#define __CPUINIT .section ".text","ax"
+#define __CPUINITDATA .section ".data","aw"
+#else
+#define __CPUINIT __INIT
+#define __CPUINITDATA __INITDATA
+#endif
Maybe some wires got crossed along the submit route... Russell, I'll
submit a fix against the latest tree.
P.
next prev parent reply other threads:[~2007-05-08 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 13:49 Please revert 86c0baf123e474b6eb404798926ecf62b426bf3a Russell King
2007-05-08 14:07 ` Prarit Bhargava [this message]
2007-05-08 15:17 ` Linus Torvalds
2007-05-08 15:19 ` Prarit Bhargava
2007-05-08 15:54 ` Russell King
2007-05-08 15:56 ` Prarit Bhargava
2007-05-13 10:56 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46408424.6050301@redhat.com \
--to=prarit@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@basil.nowhere.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox