From: "H. Peter Anvin" <hpa@zytor.com>
To: Alexander van Heukelum <heukelum@mailshack.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Antonino A. Daplas" <adaplas@gmail.com>, Andi Kleen <ak@suse.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Make bootsector stub 16-bit-only (i386)
Date: Tue, 08 May 2007 11:45:47 -0700 [thread overview]
Message-ID: <4640C55B.6030908@zytor.com> (raw)
In-Reply-To: <20070508183232.GA13225@mailshack.com>
Alexander van Heukelum wrote:
>
> Oh! A padding hole in a struct! That could be a problem. If the freeze
> is after decompression, could you test if this makes it work again?
>
The correct fix is to apply __attribute__((packed)) to this structure.
Of course, changing the boot sector will cause different random values
to be poked into this field...
I actually caught this during my setup code rewrite, but I forgot that
in the old setup code the parameter structure overlays the boot sector
(it doesn't in my code -- it starts out with nice clean zero-filled memory.)
-hpa
next prev parent reply other threads:[~2007-05-08 18:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 10:44 [PATCH] Make bootsector stub 16-bit-only (i386) Alexander van Heukelum
2007-05-05 18:07 ` H. Peter Anvin
2007-05-08 10:28 ` Andrew Morton
2007-05-08 11:25 ` H. Peter Anvin
2007-05-08 12:27 ` Andi Kleen
2007-05-08 17:13 ` H. Peter Anvin
2007-05-08 18:12 ` Andrew Morton
2007-05-08 18:27 ` H. Peter Anvin
2007-05-08 18:32 ` Alexander van Heukelum
2007-05-08 18:45 ` H. Peter Anvin [this message]
2007-05-08 19:19 ` Alexander van Heukelum
2007-05-08 22:27 ` H. Peter Anvin
2007-05-08 20:00 ` Andrew Morton
2007-05-09 0:04 ` Antonino A. Daplas
2007-05-09 8:54 ` Alexander van Heukelum
2007-05-09 13:45 ` Antonino A. Daplas
2007-05-09 16:51 ` H. Peter Anvin
2007-05-09 18:18 ` Alexander van Heukelum
2007-05-09 18:27 ` H. Peter Anvin
2007-05-09 14:30 ` Lennart Sorensen
2007-05-09 14:51 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4640C55B.6030908@zytor.com \
--to=hpa@zytor.com \
--cc=adaplas@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=heukelum@mailshack.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox