From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Chris Wright <chrisw@sous-sol.org>,
Rusty Russell <rusty@rustcorp.com.au>,
David Howells <dhowells@redhat.com>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>
Subject: Re: [patch 3/4] split usermodehelper setup from execution
Date: Tue, 08 May 2007 15:00:44 -0700 [thread overview]
Message-ID: <4640F30C.7080901@goop.org> (raw)
In-Reply-To: <20070508150156.402980c6.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> On Tue, 08 May 2007 13:51:32 -0700 Jeremy Fitzhardinge wrote:
>
>
>> --- a/kernel/kmod.c
>> +++ b/kernel/kmod.c
>> @@ -253,11 +262,94 @@ static void __call_usermodehelper(struct
>> }
>>
>> /**
>> - * call_usermodehelper_keys - start a usermode application
>> - * @path: pathname for the application
>> - * @argv: null-terminated argument list
>> - * @envp: null-terminated environment list
>> - * @session_keyring: session keyring for process (NULL for an empty keyring)
>> + * call_usermodehelper_setup - prepare to call a usermode helper
>> + * @path - path to usermode executable
>> + * @argv - arg vector for process
>> + * @envp - environment for process
>>
>
> s / - /: / above please.
>
The power of cut'n'paste makes the errors consistent, at least... Will
fix up.
J
next prev parent reply other threads:[~2007-05-08 22:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 20:51 [patch 0/4] A series of cleanup patches Jeremy Fitzhardinge
2007-05-08 20:51 ` [patch 1/4] add kstrndup Jeremy Fitzhardinge
2007-05-08 21:56 ` Randy Dunlap
2007-05-08 20:51 ` [patch 2/4] add argv_split() Jeremy Fitzhardinge
2007-05-08 21:59 ` Randy Dunlap
2007-05-08 22:31 ` Jan Engelhardt
2007-05-08 22:36 ` Jeremy Fitzhardinge
2007-05-08 20:51 ` [patch 3/4] split usermodehelper setup from execution Jeremy Fitzhardinge
2007-05-08 22:01 ` Randy Dunlap
2007-05-08 22:00 ` Jeremy Fitzhardinge [this message]
2007-05-08 22:10 ` Randy Dunlap
2007-05-08 23:49 ` Rusty Russell
2007-05-09 0:00 ` Jeremy Fitzhardinge
2007-05-08 20:51 ` [patch 4/4] Add common orderly_poweroff() Jeremy Fitzhardinge
2007-05-08 21:45 ` Len Brown
2007-05-08 22:06 ` Randy Dunlap
2007-05-09 12:52 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4640F30C.7080901@goop.org \
--to=jeremy@goop.org \
--cc=B.Steinbrink@gmx.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox