From: Jeff Garzik <jeff@garzik.org>
To: Stephen.Clark@seclark.us
Cc: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
Randy Dunlap <randy.dunlap@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: CodingStyle: start flamewar about use of braces
Date: Tue, 08 May 2007 19:01:20 -0400 [thread overview]
Message-ID: <46410140.7050205@garzik.org> (raw)
In-Reply-To: <4640FEA0.3020407@seclark.us>
Stephen Clark wrote:
> Lennart Sorensen wrote:
>> On Tue, May 08, 2007 at 05:19:45PM -0400, Jeff Garzik wrote:
>>> If anyone tries to add braces to my code's 'else' statements where
>>> they are not required, that patch will get NAK'd in a heartbeat.
>> Oh isn't coding style fun. I personally hate code that doesn't ALWAYS
>> have the braces everywhere since it makes adding a print statement
>> or other debuging to the condition such a pain since you then have to
>> add braces to the condition to avoid breaking the code just to insert
>> a print statement. It is one of the few things I disagree with in the
>> linux kernel coding style.
> I agree - it is merely defensive programming to always have the braces,
> it prevents someone
> from sticking in a diag and forgetting to add braces so things go haywire.
If you compulsively add braces where not needed, the number of lines in
the source file explodes. Net result is code that is more difficult to
read, because far fewer lines of code fit on a single page/screen.
But hey, it's personal preference. I'm not going to enforce the
make-code-more-readable rule on others' code... :)
Jeff
next prev parent reply other threads:[~2007-05-08 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705081903.l48J3AOw010373@hera.kernel.org>
2007-05-08 19:43 ` CodingStyle: start flamewar about use of braces Randy Dunlap
2007-05-08 21:19 ` Jeff Garzik
2007-05-08 22:25 ` Lennart Sorensen
2007-05-08 22:50 ` Stephen Clark
2007-05-08 23:01 ` Jeff Garzik [this message]
2007-05-08 23:37 ` Satyam Sharma
2007-05-09 8:16 ` Stefan Richter
2007-05-09 8:59 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46410140.7050205@garzik.org \
--to=jeff@garzik.org \
--cc=Stephen.Clark@seclark.us \
--cc=linux-kernel@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox