* Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
@ 2007-05-09 2:56 H. Peter Anvin
2007-05-09 3:05 ` Jeff Garzik
2007-05-09 5:56 ` Antonino A. Daplas
0 siblings, 2 replies; 9+ messages in thread
From: H. Peter Anvin @ 2007-05-09 2:56 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Antonino A. Daplas, Linux Kernel Mailing List
Checkin 464bdd33e9baad9806c7adbd8dfc37081a55f27e "fbdev: ignore VESA
modes if framebuffer is disabled" is just plain wrong on any system
which has support for extended text modes in its VESA BIOS.
Antonio is incorrectly assuming this branchout is used only to set VESA
graphics modes, but it's to set any VESA mode, be it text or graphics.
-pa
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
2007-05-09 2:56 Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e H. Peter Anvin
@ 2007-05-09 3:05 ` Jeff Garzik
2007-05-09 3:18 ` H. Peter Anvin
` (2 more replies)
2007-05-09 5:56 ` Antonino A. Daplas
1 sibling, 3 replies; 9+ messages in thread
From: Jeff Garzik @ 2007-05-09 3:05 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Linus Torvalds, Antonino A. Daplas, Linux Kernel Mailing List
H. Peter Anvin wrote:
> Checkin 464bdd33e9baad9806c7adbd8dfc37081a55f27e "fbdev: ignore VESA
> modes if framebuffer is disabled" is just plain wrong on any system
> which has support for extended text modes in its VESA BIOS.
>
> Antonio is incorrectly assuming this branchout is used only to set VESA
> graphics modes, but it's to set any VESA mode, be it text or graphics.
I wonder if this fbdev update is what causes my X session to die?
I'm using the VESA driver on my ATI R580, and just filed this bug report
minutes ago: http://lkml.org/lkml/2007/5/8/667
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
2007-05-09 3:05 ` Jeff Garzik
@ 2007-05-09 3:18 ` H. Peter Anvin
2007-05-09 3:33 ` Linus Torvalds
2007-05-09 6:02 ` Antonino A. Daplas
2 siblings, 0 replies; 9+ messages in thread
From: H. Peter Anvin @ 2007-05-09 3:18 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Antonino A. Daplas, Linux Kernel Mailing List
Jeff Garzik wrote:
> H. Peter Anvin wrote:
>> Checkin 464bdd33e9baad9806c7adbd8dfc37081a55f27e "fbdev: ignore VESA
>> modes if framebuffer is disabled" is just plain wrong on any system
>> which has support for extended text modes in its VESA BIOS.
>>
>> Antonio is incorrectly assuming this branchout is used only to set VESA
>> graphics modes, but it's to set any VESA mode, be it text or graphics.
>
> I wonder if this fbdev update is what causes my X session to die?
>
> I'm using the VESA driver on my ATI R580, and just filed this bug report
> minutes ago: http://lkml.org/lkml/2007/5/8/667
>
Perhaps, but not due to this partiular patch. :)
-hpa
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
2007-05-09 3:05 ` Jeff Garzik
2007-05-09 3:18 ` H. Peter Anvin
@ 2007-05-09 3:33 ` Linus Torvalds
2007-05-09 3:55 ` Jeff Garzik
2007-05-09 6:02 ` Antonino A. Daplas
2 siblings, 1 reply; 9+ messages in thread
From: Linus Torvalds @ 2007-05-09 3:33 UTC (permalink / raw)
To: Jeff Garzik; +Cc: H. Peter Anvin, Antonino A. Daplas, Linux Kernel Mailing List
On Tue, 8 May 2007, Jeff Garzik wrote:
>
> I wonder if this fbdev update is what causes my X session to die?
Not that particular patch, but yeah, it could certainly be the fbdev
update.
Can you try bisecting it?
Linus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
2007-05-09 3:05 ` Jeff Garzik
2007-05-09 3:18 ` H. Peter Anvin
2007-05-09 3:33 ` Linus Torvalds
@ 2007-05-09 6:02 ` Antonino A. Daplas
2 siblings, 0 replies; 9+ messages in thread
From: Antonino A. Daplas @ 2007-05-09 6:02 UTC (permalink / raw)
To: Jeff Garzik; +Cc: H. Peter Anvin, Linus Torvalds, Linux Kernel Mailing List
On Tue, 2007-05-08 at 23:05 -0400, Jeff Garzik wrote:
> H. Peter Anvin wrote:
> > Checkin 464bdd33e9baad9806c7adbd8dfc37081a55f27e "fbdev: ignore VESA
> > modes if framebuffer is disabled" is just plain wrong on any system
> > which has support for extended text modes in its VESA BIOS.
> >
> > Antonio is incorrectly assuming this branchout is used only to set VESA
> > graphics modes, but it's to set any VESA mode, be it text or graphics.
>
> I wonder if this fbdev update is what causes my X session to die?
That's doubtful though, CONFIG_FB=n. For a start, you can try reverting
changes in drivers/char/vt.c and drivers/video/console/vgacon.c
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
2007-05-09 2:56 Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e H. Peter Anvin
2007-05-09 3:05 ` Jeff Garzik
@ 2007-05-09 5:56 ` Antonino A. Daplas
2007-05-09 5:59 ` H. Peter Anvin
1 sibling, 1 reply; 9+ messages in thread
From: Antonino A. Daplas @ 2007-05-09 5:56 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Linus Torvalds, Linux Kernel Mailing List
On Tue, 2007-05-08 at 19:56 -0700, H. Peter Anvin wrote:
> Checkin 464bdd33e9baad9806c7adbd8dfc37081a55f27e "fbdev: ignore VESA
> modes if framebuffer is disabled" is just plain wrong on any system
> which has support for extended text modes in its VESA BIOS.
>
> Antonio is incorrectly assuming this branchout is used only to set VESA
> graphics modes, but it's to set any VESA mode, be it text or graphics.
>
Okay.
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
2007-05-09 5:56 ` Antonino A. Daplas
@ 2007-05-09 5:59 ` H. Peter Anvin
2007-05-09 6:16 ` Antonino A. Daplas
0 siblings, 1 reply; 9+ messages in thread
From: H. Peter Anvin @ 2007-05-09 5:59 UTC (permalink / raw)
To: Antonino A. Daplas; +Cc: Linus Torvalds, Linux Kernel Mailing List
Antonino A. Daplas wrote:
> On Tue, 2007-05-08 at 19:56 -0700, H. Peter Anvin wrote:
>> Checkin 464bdd33e9baad9806c7adbd8dfc37081a55f27e "fbdev: ignore VESA
>> modes if framebuffer is disabled" is just plain wrong on any system
>> which has support for extended text modes in its VESA BIOS.
>>
>> Antonio is incorrectly assuming this branchout is used only to set VESA
>> graphics modes, but it's to set any VESA mode, be it text or graphics.
>>
>
> Okay.
>
I did, however, take a cue from this and the setup rewrite now makes the
VESA graphics mode unselectable if CONFIG_FB is off.
See:
http://git.kernel.org/?p=linux/kernel/git/hpa/linux-2.6-newsetup.git;a=shortlog
-hpa
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
2007-05-09 5:59 ` H. Peter Anvin
@ 2007-05-09 6:16 ` Antonino A. Daplas
0 siblings, 0 replies; 9+ messages in thread
From: Antonino A. Daplas @ 2007-05-09 6:16 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Linus Torvalds, Linux Kernel Mailing List
On Tue, 2007-05-08 at 22:59 -0700, H. Peter Anvin wrote:
> Antonino A. Daplas wrote:
> > On Tue, 2007-05-08 at 19:56 -0700, H. Peter Anvin wrote:
> >> Checkin 464bdd33e9baad9806c7adbd8dfc37081a55f27e "fbdev: ignore VESA
> >> modes if framebuffer is disabled" is just plain wrong on any system
> >> which has support for extended text modes in its VESA BIOS.
> >>
> >> Antonio is incorrectly assuming this branchout is used only to set VESA
> >> graphics modes, but it's to set any VESA mode, be it text or graphics.
> >>
> >
> > Okay.
> >
>
> I did, however, take a cue from this and the setup rewrite now makes the
> VESA graphics mode unselectable if CONFIG_FB is off.
>
Ah, okay, thanks.
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2007-05-09 6:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-09 2:56 Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e H. Peter Anvin
2007-05-09 3:05 ` Jeff Garzik
2007-05-09 3:18 ` H. Peter Anvin
2007-05-09 3:33 ` Linus Torvalds
2007-05-09 3:55 ` Jeff Garzik
2007-05-09 6:02 ` Antonino A. Daplas
2007-05-09 5:56 ` Antonino A. Daplas
2007-05-09 5:59 ` H. Peter Anvin
2007-05-09 6:16 ` Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox