From: David Howells <dhowells@redhat.com>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: dhowells@redhat.com, "krzk@kernel.org" <krzk@kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"smayhew@redhat.com" <smayhew@redhat.com>,
"anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Subject: Re: [BISECT BUG] NFS v4 root not working after 6d972518b821 ("NFS: Add fs_context support.")
Date: Fri, 17 Jan 2020 15:44:29 +0000 [thread overview]
Message-ID: <464191.1579275869@warthog.procyon.org.uk> (raw)
In-Reply-To: <b31b09abeea4982e038b0e66e45889bb2c9df750.camel@hammerspace.com>
Trond Myklebust <trondmy@hammerspace.com> wrote:
> It looks like someone changed the return value from the old EINVAL to
> something else? The "Numerical result out of range" message above
> suggests it has been changed to EOVERFLOW, which probably is not
> supported by 'mount'.
Ah, I see what's happened. nfs_get_option_ui_bound() returns -ERANGE and the
new code lets this through whereas the old code converted it to -EINVAL.
David
next prev parent reply other threads:[~2020-01-17 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 11:33 [BISECT BUG] NFS v4 root not working after 6d972518b821 ("NFS: Add fs_context support.") Krzysztof Kozlowski
2020-01-17 0:49 ` Scott Mayhew
2020-01-17 11:53 ` Krzysztof Kozlowski
2020-01-17 12:54 ` David Howells
2020-01-17 13:16 ` Krzysztof Kozlowski
2020-01-17 14:08 ` David Howells
2020-01-17 14:36 ` Krzysztof Kozlowski
2020-01-17 14:20 ` David Howells
2020-01-17 14:40 ` Krzysztof Kozlowski
2020-01-17 15:12 ` David Howells
2020-01-17 15:17 ` Trond Myklebust
2020-01-17 15:32 ` Scott Mayhew
2020-01-17 15:44 ` David Howells [this message]
2020-01-17 15:48 ` [PATCH] nfs: Return EINVAL rather than ERANGE for mount parse errors David Howells
2020-01-17 15:55 ` [PATCH v2] " David Howells
2020-01-17 16:51 ` Krzysztof Kozlowski
2020-01-17 17:18 ` David Howells
2020-01-17 20:21 ` Schumaker, Anna
2020-01-17 21:12 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464191.1579275869@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=arnd@arndb.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
--cc=trondmy@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox