Re: [git pull] New firewire stack

Adrian Bunk
2007-05-02T15:27:34Z

On Wed, May 02, 2007 at 02:48:11PM +0200, Stefan Richter wrote:
> Olaf Hering wrote:
> > On Tue, May 01, Kristian Høgsberg wrote:
> >
> >> drivers/firewire/Kconfig | 60 ++
> >
> > NACK.
> > Upgrade the current drivers/ieee1394/ with the new code,
>
> Last time I believe I was the only one who asked whether to put it into
> drivers/ieee1394 instead of another directory. Of course I acknowledge
> that everytime a new review round is started, people do reconsider.
> Especially since we had a gap of a few months since the last LKML review.
>
> > and keep all existing module names.
>
> I'm impartial to that. Using same names might ease the transition from
> the userspace side, as far as there is userland which relies on module
> names.
>
> A certain drawback of same names would be that geeks cannot install both
> stacks at once during the transition period. Therefore, checking
> whether eventual problems are in fact regressions involves a module
> unload/ configure/ build/ install/ reload cycle, instead of just module
> unload/ reload. This especially means we can only get help from testers
> who are able to build kernels.
>
> Other opinions?

An advantage of changing the names is that they are now prefixed.
But looking at them, there will again be the point whether everyone will
think that "fw" is firmware, and perhaps switching to the (although
longer) prefix "firewire" might make sense?

> Stefan Richter

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed