Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

Pekka Enberg
2007-05-02T20:35:51Z

On 5/2/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> I looked around a bit with grep -R and a few search terms but didn't
> find something definite. Is there any other user of a crc16_itu_t or
> crc_ccitt or whatever which operates on a (CPU byte ordered) u32[]
> instead of on a (network byte ordered) u8[]?

I was referring to this: http://lkml.org/lkml/2006/6/12/137

On 5/2/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> The only value in having a shared implementation would be a potentially
> smaller kernel. Sharing it to ensure correctness is not an issue;
> fw-topology.c::crc16_itu_t is simply the one in IEEE 1212 table 5.
> Performance is also not an issue (if better algorithms exist) because
> the FireWire stack uses it only infrequently on a moderate amount of data.

Yeah, it's not a biggie, but we do have a tradition of putting
generally useful things into lib/ so that everyone doesn't invent
their own.