Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

Kristian Høgsberg
2007-05-02T21:18:34Z

Pekka Enberg wrote:
> On 5/2/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>> +/* The lib/crc16.c implementation uses the standard (0x8005)
>> + * polynomial, but we need the ITU-T (or CCITT) polynomial (0x1021).
>> + * The implementation below works on an array of host-endian u32
>> + * words, assuming they'll be transmited msb first. */
>> +u16
>> +crc16_itu_t(const u32 *buffer, size_t length)
>> +{
>
> [snip]
>
> So put it in lib/crc-itu-t.c? Btw, there's apparently another ITU-T
> implementation floating around by Ivo van Doorn.

I looked into this a while back, and the kernel does have a CCITT based crc16
function. The problem is that it works on the opposite bit order from what I
need, so to use it I'll have to bitswap every byte as it goes in and then
bitswap the resulting crc16. That's more code and probably less efficient
than just implementing the crc itself. I wouldn't mind moving it to lib/
though, but nobody else in the kernel is using this bit order.

Kristian