Re: [PATCH] Use tty_schedule in VT code.

Paul Fulghum
2007-07-17T20:02:51Z

James Simmons wrote:
> Because sometimes you do want the delay. In other parts of the tty
> code we do delay. What should be done is

Correct, so we must stick with the delayed work structure
which requires calling the delayed work function.

> if (tty->low_latency)
> flush_to_ldisc(&tty->buf.work.work);
> else
> schedule_delayed_work(&tty->buf.work, 1);
>
> Is this acceptable to you?

That does not make sense to me.

If you are calling from interrupt context, you do not want
to call flush_to_ldisc() directly regardless of low_latency.
This used to be the way it was done and it ended up causing
deadlocks in just that situation.

And the initial schedule has no reason to add the extra delay.

--
Paul Fulghum
Microgate Systems, Ltd.