From: Rene Herman <rene.herman@gmail.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Andrew Morton <akpm@osdl.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: New Mitsumi legacy CD-ROM driver
Date: Thu, 10 May 2007 17:54:04 +0200 [thread overview]
Message-ID: <4643401C.2080905@gmail.com> (raw)
In-Reply-To: <20070508134944.GO4163@kernel.dk>
On 05/08/2007 03:49 PM, Jens Axboe wrote:
> The key is that you have to have interrupts disabled for the highmem
> case, which may complicate your driver (or just make it perform worse,
> from the system POV). If you let the block layer bounce, then you can
> just use page_address() and don't worry about disabling interrupts.
Okay, yes, thank you, the mapping is gone. The data-transfer loop has now
turned into just:
rq_for_each_bio(bio, req)
bio_for_each_segment(bvec, bio, segno)
ioread8_rep(mcd->ioaddr, page_address(bvec->bv_page) +
bvec->bv_offset, bvec->bv_len);
> - Or, it's a newer system and the nerd in you likes to play with ancient
> CD-ROM drives.
And he has long since driven out most of my other personalities...
> Fine with me... As far as I am concerned, you are now the legacy CD-ROM
> driver maintainer :-)
Yippie :-)
Rene.
next prev parent reply other threads:[~2007-05-10 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 9:42 New Mitsumi legacy CD-ROM driver Rene Herman
2007-05-08 9:44 ` Rene Herman
2007-05-08 10:35 ` Jens Axboe
2007-05-08 13:39 ` Rene Herman
2007-05-08 13:49 ` Jens Axboe
2007-05-08 13:57 ` Pekka J Enberg
2007-05-08 14:04 ` Jens Axboe
2007-05-08 14:20 ` Rene Herman
2007-05-10 15:54 ` Rene Herman [this message]
2007-05-08 13:53 ` Pekka Enberg
2007-05-08 13:53 ` Jens Axboe
2007-05-08 14:17 ` Rene Herman
2007-05-08 14:34 ` Pekka J Enberg
2007-05-08 14:27 ` Pekka Enberg
2007-05-08 20:13 ` Ondrej Zary
2007-05-08 21:12 ` Bob Tracy
2007-05-10 16:03 ` Rene Herman
2007-05-10 15:59 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4643401C.2080905@gmail.com \
--to=rene.herman@gmail.com \
--cc=akpm@osdl.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox