From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Roland McGrath <roland@redhat.com>
Cc: Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Chris Wright <chrisw@sous-sol.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.com>
Subject: Re: [patch 2/7] use elfnote.h to generate vsyscall notes.
Date: Fri, 11 May 2007 13:06:17 -0700 [thread overview]
Message-ID: <4644CCB9.3040109@goop.org> (raw)
In-Reply-To: <20070511194725.E37E51F8512@magilla.localdomain>
Roland McGrath wrote:
> I used .balign because .align has inconsistent meaning on some platforms
> (matches .p2align instead of .balign). Using .align in a
> machine-independent file seems questionable.
>
>
>
Subject: use balign in elfnote.h
Roland McGrath <roland@redhat.com>:
> I used .balign because .align has inconsistent meaning on some platforms
> (matches .p2align instead of .balign). Using .align in a
> machine-independent file seems questionable.
Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
Cc: Roland McGrath <roland@redhat.com>
---
include/linux/elfnote.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
===================================================================
--- a/include/linux/elfnote.h
+++ b/include/linux/elfnote.h
@@ -40,16 +40,16 @@
*/
#define ELFNOTE_START(name, type, flags) \
.pushsection .note.name, flags,@note ; \
- .align 4 ; \
+ .balign 4 ; \
.long 2f - 1f /* namesz */ ; \
.long 4484f - 3f /* descsz */ ; \
.long type ; \
1:.asciz #name ; \
-2:.align 4 ; \
+2:.balign 4 ; \
3:
#define ELFNOTE_END \
-4484:.align 4 ; \
+4484:.balign 4 ; \
.popsection ;
#define ELFNOTE(name, type, desc) \
next prev parent reply other threads:[~2007-05-11 20:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 23:57 [patch 0/7] A series of cleanup patches Jeremy Fitzhardinge
2007-05-10 23:57 ` [patch 1/7] i386: move common parts of smp into their own file Jeremy Fitzhardinge
2007-05-10 23:57 ` [patch 2/7] use elfnote.h to generate vsyscall notes Jeremy Fitzhardinge
2007-05-11 19:47 ` Roland McGrath
2007-05-11 19:48 ` Jeremy Fitzhardinge
2007-05-11 20:06 ` Jeremy Fitzhardinge [this message]
2007-05-10 23:57 ` [patch 3/7] add kstrndup Jeremy Fitzhardinge
2007-05-11 20:52 ` René Scharfe
2007-05-11 21:18 ` Jeremy Fitzhardinge
2007-05-10 23:57 ` [patch 4/7] add argv_split() Jeremy Fitzhardinge
2007-05-11 22:57 ` Randy Dunlap
2007-05-10 23:57 ` [patch 5/7] split usermodehelper setup from execution Jeremy Fitzhardinge
2007-05-10 23:57 ` [patch 6/7] Add common orderly_poweroff() Jeremy Fitzhardinge
2007-05-11 22:56 ` Randy Dunlap
2007-07-16 19:52 ` Andrew Morton
2007-07-16 19:59 ` Jeremy Fitzhardinge
2007-07-16 21:31 ` David Miller
2007-07-16 21:42 ` Andrew Morton
2007-05-10 23:57 ` [patch 7/7] tidy up usermode helper waiting a bit Jeremy Fitzhardinge
2007-05-11 19:45 ` Johannes Berg
2007-05-11 20:01 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4644CCB9.3040109@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox