[PATCH] IPMI: fix SI address space settings

[PATCH] IPMI: fix SI address space settings

[Corey Minyard]

From: Corey Minyard <minyard@acm.org>
Fix a rather obvious error that Patrick found in the setup routines.
Need to set the proper address space in the ACPI case.

Signed-off-by: Corey Minyard <minyard@acm.org>
Cc: Patrick Schoeller <Patrick.Schoeller@hp.com>

Index: linux-2.6.21/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux-2.6.21.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6.21/drivers/char/ipmi/ipmi_si_intf.c
@@ -1915,10 +1915,10 @@ static __devinit int try_init_acpi(struc
 
 	if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) {
 		info->io_setup = mem_setup;
-		info->io.addr_type = IPMI_IO_ADDR_SPACE;
+		info->io.addr_type = IPMI_MEM_ADDR_SPACE;
 	} else if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_IO) {
 		info->io_setup = port_setup;
-		info->io.addr_type = IPMI_MEM_ADDR_SPACE;
+		info->io.addr_type = IPMI_IO_ADDR_SPACE;
 	} else {
 		kfree(info);
 		printk("ipmi_si: Unknown ACPI I/O Address type\n");

Re: [PATCH] IPMI: fix SI address space settings

[Andrew Morton]

On Fri, 11 May 2007 07:56:16 -0500
Corey Minyard <minyard@acm.org> wrote:

> Fix a rather obvious error that Patrick found in the setup routines.
> Need to set the proper address space in the ACPI case.

I have assumed that both these fixes are desired in 2.6.21.x.

In general, it helps if people can think about that and express an
explicit opinion when sending fixes, please.

Re: [PATCH] IPMI: fix SI address space settings

[Corey Minyard]

Andrew Morton wrote:
> On Fri, 11 May 2007 07:56:16 -0500
> Corey Minyard <minyard@acm.org> wrote:
>
>   
>> Fix a rather obvious error that Patrick found in the setup routines.
>> Need to set the proper address space in the ACPI case.
>>     
>
> I have assumed that both these fixes are desired in 2.6.21.x.
>   
The ACPI fix can go to 2.6.21.x.

The PPC openfirmware one is a fix for a patch that just went in for 
2.6.22.  So that one doesn't need to be put in 2.6.21.x.
> In general, it helps if people can think about that and express an
> explicit opinion when sending fixes, please.
>   
Will do.  Thanks.

-corey