From: jimmy bahuleyan <knight.camelot@gmail.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Satyam Sharma <satyam.sharma@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Johannes Stezenbach <js@linuxtv.org>,
Jesper Juhl <jesper.juhl@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Heikki Orsila <shdl@zakalwe.fi>
Subject: Re: [PATCH] "volatile considered harmful", take 3
Date: Sat, 12 May 2007 13:03:50 +0530 [thread overview]
Message-ID: <46456DDE.5070006@gmail.com> (raw)
In-Reply-To: <46456B18.9060605@s5r6.in-berlin.de>
Stefan Richter wrote:
> Satyam Sharma wrote:
>> Coming back to the document, we do need to document / find
>> consensus on the "preferred" way to do similar business in the
>> kernel, and my opinion as far as that is concerned is to shun
>> volatile wherever possible (which includes the case originally
>> discussed above).
>
> I too recommend that volatile-considered-harmful.txt is not watered down
> by an ever growing "but if" list. If anybody knows what he does, he
> still can program in a deviating way --- provided that he leaves a brief
> comment in the code, telling why it is possible and beneficial to use
> the volatile qualifier in this special case.
yes, this seems the better option. generally, the more complex rules you
have, the more people tend to break it (either through not being able t
comprehend it or cos it's too difficult to follow).
i believe, the doc here is pretty unambiguous regarding the fact that
volatile should be avoided. And as Stefan pointed out, anyone who feels
the need to use, must surely _know_ what he is doing & hence is in a
position t make that decision (followed ofcourse with a doc of why it
was done).
it would be better we didn't grow the list of exceptions - IMHO.
-jb
--
Tact is the art of making a point without making an enemy.
next prev parent reply other threads:[~2007-05-12 7:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 17:36 [PATCH] "volatile considered harmful", take 3 Jonathan Corbet
2007-05-11 21:25 ` Jesper Juhl
2007-05-12 3:21 ` Satyam Sharma
2007-05-12 4:29 ` Jeff Garzik
2007-05-12 5:34 ` H. Peter Anvin
2007-05-12 5:41 ` H. Peter Anvin
2007-05-12 6:15 ` Satyam Sharma
2007-05-12 6:21 ` H. Peter Anvin
2007-05-12 7:02 ` Satyam Sharma
2007-05-12 7:13 ` H. Peter Anvin
2007-05-12 7:28 ` Satyam Sharma
2007-05-12 7:53 ` Stefan Richter
2007-05-12 11:51 ` Heikki Orsila
2007-05-12 18:06 ` H. Peter Anvin
2007-05-12 7:22 ` Stefan Richter
2007-05-12 7:33 ` jimmy bahuleyan [this message]
2007-05-12 7:45 ` Jeff Garzik
2007-05-12 19:17 ` Dr. David Alan Gilbert
[not found] <8jHg3-1T2-5@gated-at.bofh.it>
[not found] ` <8jQt5-7As-3@gated-at.bofh.it>
[not found] ` <8jSuQ-28J-21@gated-at.bofh.it>
[not found] ` <8jT7y-39x-9@gated-at.bofh.it>
2007-05-13 0:00 ` Bodo Eggert
2007-05-14 3:37 ` Satyam Sharma
2007-05-17 23:51 ` Bill Davidsen
2007-05-18 3:13 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46456DDE.5070006@gmail.com \
--to=knight.camelot@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=hpa@zytor.com \
--cc=jesper.juhl@gmail.com \
--cc=js@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=satyam.sharma@gmail.com \
--cc=shdl@zakalwe.fi \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox