public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Kirill Korotaev <dev@sw.ru>
Cc: Paul Menage <menage@google.com>,
	vatsa@in.ibm.com, linux-kernel@vger.kernel.org, xemul@sw.ru,
	akpm@linux-foundation.org, devel@openvz.org
Subject: Re: [RFC][PATCH] Per container statistics
Date: Tue, 15 May 2007 12:53:00 +0530	[thread overview]
Message-ID: <46495FD4.9080607@linux.vnet.ibm.com> (raw)
In-Reply-To: <46495D4C.7040401@sw.ru>

Kirill Korotaev wrote:
> oh, please no... Andrew, this loop can be very very long when having > 10,000 tasks on the machine...
> we have had enough such issues in OpenVZ and just don't want to come through this again.
> Also sum of RUNNING + UNINTERRUPTIBLE is required for per-container loadavg calculations.
> 

Hi, Kirill,

I've asked Paul Menage to help us with this scenario by adding a per-container task list.
Would you be ok, if we walked the per-container task list. We could further optimize
the routine by adding

1. A container id (avoid parsing file paths to uniquely identify a container)
2. If we cannot do (1), then cache container paths

The other option is of-course what Pavel posted, but I think the amortized cost of tracking
task state at the time of task state change or looping over tasks on demand should be the
same.

Do you agree in general with containerstats? How we build (walk the task list or at the
time of task state change) is flexible with containerstats.

Thanks for your comments!

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

  reply	other threads:[~2007-05-15  7:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-14 17:44 [RFC][PATCH] Per container statistics Balbir Singh
2007-05-15  7:12 ` Kirill Korotaev
2007-05-15  7:23   ` Balbir Singh [this message]
2007-05-21 20:56 ` Paul Menage
2007-05-24 15:59   ` Balbir Singh
2007-05-24 16:12     ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46495FD4.9080607@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dev@sw.ru \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=vatsa@in.ibm.com \
    --cc=xemul@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox