From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH 2/2] AFS: Implement shared-writable mmap
Date: Wed, 16 May 2007 10:41:31 +1000 [thread overview]
Message-ID: <464A533B.8040507@yahoo.com.au> (raw)
In-Reply-To: <20070515144007.f87d9be5.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Tue, 15 May 2007 16:52:31 +0100
> David Howells <dhowells@redhat.com> wrote:
>
>
>>Implement shared-writable mmap for AFS.
>
>
> This blows up in -mm:
>
> fs/afs/file.c:59: error: 'filemap_nopage' undeclared here (not in a function)
> fs/afs/file.c:60: error: unknown field 'populate' specified in initializer
> fs/afs/file.c:60: error: 'filemap_populate' undeclared here (not in a function)
>
> because Nick went and renamed half the VM and deleted the other half.
And page_mkwrite is next ;)
> I need to work out what to do with
>
> mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch
> mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch
> mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-doc-fix.patch
> mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-fix.patch
> mm-merge-nopfn-into-fault.patch
> convert-hugetlbfs-to-use-vm_ops-fault.patch
> mm-remove-legacy-cruft.patch
> mm-debug-check-for-the-fault-vs-invalidate-race.patch
> mm-fix-clear_page_dirty_for_io-vs-fault-race.patch
>
> Probably merge them, I guess. Hugh had concerns, I think over small
> additional overhead from the lock_page()?
Yes he did. It seems to only be noticable in microbenchmarks. In my opinion
not enough to withhold pagecache corruption bug fixes.
Still, I have some lock_page speedup work that eliminates that regression
anyway.
However, Hugh hasn't exactly said yes or no yet...
--
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2007-05-16 0:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 15:52 [PATCH 1/2] AFS: Fix afs_prepare_write() David Howells
2007-05-15 15:52 ` [PATCH 2/2] AFS: Implement shared-writable mmap David Howells
2007-05-15 21:40 ` Andrew Morton
2007-05-16 0:41 ` Nick Piggin [this message]
2007-05-16 16:36 ` Hugh Dickins
2007-05-16 17:14 ` Nick Piggin
2007-05-16 17:26 ` Hugh Dickins
2007-05-16 17:30 ` Nick Piggin
2007-05-16 17:34 ` Chuck Ebbert
2007-05-16 17:48 ` David Howells
2007-05-16 0:32 ` Nick Piggin
2007-05-16 7:10 ` Christoph Hellwig
2007-05-16 7:17 ` Nick Piggin
2007-05-16 0:24 ` [PATCH 1/2] AFS: Fix afs_prepare_write() Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464A533B.8040507@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox