From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Satyam Sharma <satyam.sharma@gmail.com>,
Nate Diller <nate.diller@gmail.com>
Subject: Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
Date: Wed, 16 May 2007 14:52:05 +1000 [thread overview]
Message-ID: <464A8DF5.2010903@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0705152100010.5091@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Tue, 15 May 2007, Andrew Morton wrote:
>
>
>>> The functions above default to KM_USER0 which is also always used when
>>> zero_user_page was called except in one single case. We open code that
>>> single case to draw attention to the spot.
>>>
>>
>>Dunno. fwiw, we decided to _not_ embed KM_USER0 in the callee: we have had
>>some pretty ghastly bugs in the past due to misuse of kmap slots so the
>>idea was to shove the decision into the caller's face, make them think
>>about what they're doing
>
>
> On the other hand non highmem platforms are burdened with always repeating
> the same KM_USER0 in every function call. Isnt it enough to know that
> standard functions use KM_USER0 for their operations?
Couldn't that be filtered out inline?
--
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2007-05-16 4:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 3:00 Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user Christoph Lameter
2007-05-16 3:24 ` Andrew Morton
2007-05-16 4:05 ` Christoph Lameter
2007-05-16 4:52 ` Nick Piggin [this message]
2007-05-16 5:29 ` Andrew Morton
2007-05-16 5:51 ` Nick Piggin
2007-05-16 6:13 ` Christoph Lameter
2007-05-16 6:19 ` Nick Piggin
2007-05-16 17:39 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464A8DF5.2010903@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nate.diller@gmail.com \
--cc=satyam.sharma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox