* [PATCH 4/4] Add the combined mode for ATI SB700
@ 2007-05-16 6:53 Henry Su
2007-05-16 7:57 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Henry Su @ 2007-05-16 6:53 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, gregkh; +Cc: linux-kernel, gmail_ati
From: henry.su@amd.com
Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode.
The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver,
but now it is not necessary for Linux since the kernel has supported AHCI.
Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
-----------------------------------------------------
diff -Nur linux-2.6.21.1.orig/include/linux/pci_ids.h linux-2.6.21.1/include/linux/pci_ids.h
--- linux-2.6.21.1.orig/include/linux/pci_ids.h 2007-05-16 13:28:54.405386000 +0800
+++ linux-2.6.21.1/include/linux/pci_ids.h 2007-05-16 13:45:29.936636000 +0800
@@ -371,6 +371,9 @@
#define PCI_DEVICE_ID_ATI_IXP600_SRAID 0x4381
#define PCI_DEVICE_ID_ATI_IXP600_SMBUS 0x4385
#define PCI_DEVICE_ID_ATI_IXP600_IDE 0x438c
+#define PCI_DEVICE_ID_ATI_IXP700_SATA 0x4390
+#define PCI_DEVICE_ID_ATI_IXP700_SMBUS 0x4395
+#define PCI_DEVICE_ID_ATI_IXP700_IDE 0x439c
#define PCI_VENDOR_ID_VLSI 0x1004
#define PCI_DEVICE_ID_VLSI_82C592 0x0005
diff -Nur linux-2.6.21.1.orig/drivers/pci/quirks.c linux-2.6.21.1/drivers/pci/quirks.c
--- linux-2.6.21.1.orig/drivers/pci/quirks.c 2007-05-16 13:28:09.702261000 +0800
+++ linux-2.6.21.1/drivers/pci/quirks.c 2007-05-16 13:41:26.155386000 +0800
@@ -875,6 +875,7 @@
}
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SATA, quirk_sb600_sata);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_sb600_sata);
/*
* Serverworks CSB5 IDE does not fully support native mode
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 4/4] Add the combined mode for ATI SB700
2007-05-16 6:53 [PATCH 4/4] Add the combined mode for ATI SB700 Henry Su
@ 2007-05-16 7:57 ` Jeff Garzik
2007-05-16 8:13 ` Henry Su
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-05-16 7:57 UTC (permalink / raw)
To: Henry Su; +Cc: Bartlomiej Zolnierkiewicz, gregkh, linux-kernel, gmail_ati
Henry Su wrote:
> From: henry.su@amd.com
> Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode.
>
> The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver,
> but now it is not necessary for Linux since the kernel has supported AHCI.
hmmmm. The patch looks OK, but your description seems to indicate that
the patch is not needed?
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 4/4] Add the combined mode for ATI SB700
2007-05-16 7:57 ` Jeff Garzik
@ 2007-05-16 8:13 ` Henry Su
0 siblings, 0 replies; 3+ messages in thread
From: Henry Su @ 2007-05-16 8:13 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Bartlomiej Zolnierkiewicz, gregkh, linux-kernel, gmail_ati
hi Jeff,
this patch is used to set the SATA controller back to AHCI mode when ATI SB700 is set
as combined mode or legacy IDE mode by BIOS, without this patch, just like ATI SB600,
the SB700 SATA device will fail in these two modes.
BRs,
henry
-----Original Message-----
From: Jeff Garzik [mailto:jeff@garzik.org]
Sent: Wednesday, May 16, 2007 3:58 PM
To: Henry Su
Cc: Bartlomiej Zolnierkiewicz; gregkh@suse.de; linux-kernel@vger.kernel.org; gmail_ati
Subject: Re: [PATCH 4/4] Add the combined mode for ATI SB700
Henry Su wrote:
> From: henry.su@amd.com
> Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode.
>
> The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver,
> but now it is not necessary for Linux since the kernel has supported AHCI.
hmmmm. The patch looks OK, but your description seems to indicate that
the patch is not needed?
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-16 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-16 6:53 [PATCH 4/4] Add the combined mode for ATI SB700 Henry Su
2007-05-16 7:57 ` Jeff Garzik
2007-05-16 8:13 ` Henry Su
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox