From: Jiri Slaby <jirislaby@gmail.com>
To: Ben Collins <ben.collins@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
Ganesh Varadarajan <ganesh@veritas.com>,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH] Remove duplicate ID in ipaq driver
Date: Wed, 16 May 2007 23:04:47 +0200 [thread overview]
Message-ID: <464B71EF.8060602@gmail.com> (raw)
In-Reply-To: <1179348840.6510.16.camel@cunning>
Ben Collins napsal(a):
> Cc: Ganesh Varadarajan <ganesh@veritas.com>
> Cc: linux-usb-devel@lists.sourceforge.net
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
>
> diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
> index 4df0ec7..7c85be4 100644
> --- a/drivers/usb/serial/ipaq.c
> +++ b/drivers/usb/serial/ipaq.c
> @@ -92,7 +92,6 @@ static void ipaq_destroy_lists(struct usb_serial_port *port);
>
> static struct usb_device_id ipaq_id_table [] = {
> /* The first entry is a placeholder for the insmod-specified device */
I wonder if the people ever read the comments? ^^^^^^^^^
It's used for parameter from command line when modprobing. See ipaq_init.
> - { USB_DEVICE(0x049F, 0x0003) },
> { USB_DEVICE(0x0104, 0x00BE) }, /* Socket USB Sync */
> { USB_DEVICE(0x03F0, 0x1016) }, /* HP USB Sync */
> { USB_DEVICE(0x03F0, 0x1116) }, /* HP USB Sync 1611 */
>
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
prev parent reply other threads:[~2007-05-16 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 20:54 [PATCH] Remove duplicate ID in ipaq driver Ben Collins
2007-05-16 20:59 ` Roland Dreier
2007-05-16 21:36 ` Ben Collins
2007-05-17 12:43 ` [linux-usb-devel] " Greg KH
2007-05-17 13:02 ` Ben Collins
2007-05-17 13:32 ` Valdis.Kletnieks
2007-05-17 13:32 ` Greg KH
2007-05-16 21:04 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464B71EF.8060602@gmail.com \
--to=jirislaby@gmail.com \
--cc=ben.collins@ubuntu.com \
--cc=ganesh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox