Re: building i386 requires s390: "driver/crypto/Kconfig" sourcing s390 arch

Linda Walsh
2007-05-18T21:46:16Z

Randy Dunlap wrote:
> On Fri, 18 May 2007 12:32:47 -0700 Linda Walsh wrote:
>
>
>> Seems there is an include of s390 based config in file
>> drivers/crypto/Kconfig: source "arch/s390/crypto/Kconfig"
>>
>> The line doesn't seem to be need for an i386 build (haven't
>> tried x86_64 though).
>>
>> I take it that this was a braino?
>>
>
> Does it cause a problem? If yes, what problem?
>
----
Yes. My source tree has unrelated architectures removed,
as a result when building i386 or x86_64, the config tools try to
include files from the s390 architecture. It isn't there.
I'm building x86, why should I be including files from other
architectures. It is hierarchically unclean.

Perhaps the s390 device needs to be moved under the crypto with
the other crypto devices? If the standard that other architectures are
using is to put their devices in the crypto directory, then one might
expect all crypto devices to be there. Why should s390 stick out and
put its crypto device someplace under the s390 tree, forcing parts of the
s390 tree to be included when building other architectures?
> It looks like someone thought that all Hardware crypto devices
> should be listed under the same menu heading. Makes some sense.
>
I thought the idea was the menu reflected the options available in
the specific parts/branches -- i.e. if you have the menu option in
the crypto tree, then the source code should be there as well.

I'm not sure how flexible the include system is, but can't it be
"not included" unless compiling for ARCH_s390?