From: Simon Arlott <simon@fire.lp0.eu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
michal@logix.cz, ioe-lkml@rameria.de
Subject: Re: [PATCH (v2)] crypto: Remove pointless padlock module
Date: Sun, 20 May 2007 07:54:17 +0100 [thread overview]
Message-ID: <464FF099.1000107@simon.arlott.org.uk> (raw)
In-Reply-To: <20070520031550.GA22903@gondor.apana.org.au>
On 20/05/07 04:15, Herbert Xu wrote:
> On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote:
>> It should be a bool that doesn't select anything, the AES and SHA modules
>> will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7
>> instead of X86_32.
>
> Having it as a tristate means that we don't have to duplicate the
> dependencies and selects that each padlock algorithm would otherwise
> do. So is there actually a problem with it being a tristate?
It has nothing to compile as a module, so M makes no sense. Each algorithm
already selects CRYPTO_ALGAPI indirectly.
--
Simon Arlott
prev parent reply other threads:[~2007-05-20 6:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 23:40 [PATCH] crypto: Remove pointless padlock module Simon Arlott
2007-04-29 1:59 ` Randy Dunlap
2007-04-29 8:01 ` [PATCH (v2)] " Simon Arlott
2007-05-02 4:50 ` Herbert Xu
2007-05-18 6:45 ` Herbert Xu
2007-05-19 19:28 ` Simon Arlott
2007-05-20 2:40 ` Dave Jones
2007-05-20 3:15 ` Herbert Xu
2007-05-20 6:54 ` Simon Arlott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464FF099.1000107@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=herbert@gondor.apana.org.au \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michal@logix.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).