public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard GENOUD <richard.genoud@bootlin.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Aswath Govindraju <a-govindraju@ti.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 1/2] dt-bindings: usb/ti,am62-usb.yaml: Add ti,lane-reverse property
Date: Tue, 9 Sep 2025 11:11:40 +0200	[thread overview]
Message-ID: <464f5995-be7d-41f6-8e95-7d724e2b5308@bootlin.com> (raw)
In-Reply-To: <20250909-curvy-happy-pug-eeffda@kuoka>

Le 09/09/2025 à 09:32, Krzysztof Kozlowski a écrit :
> On Mon, Sep 08, 2025 at 06:20:51PM +0200, Richard Genoud wrote:
>> On some designs, the D+ and D- lines are swapped (on purpose or not).
>> The PHY can handle that with the LANE_REVERSE bit.
>>
>> Signed-off-by: Richard Genoud <richard.genoud@bootlin.com>
>> ---
>>   Documentation/devicetree/bindings/usb/ti,am62-usb.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
>> index f6e6d084d1c5..ba894d610af0 100644
>> --- a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
>> +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
>> @@ -36,6 +36,11 @@ properties:
>>       items:
>>         - const: ref
>>   
>> +  ti,lane-reverse:
>> +    description:
>> +      Should be present if D+ and D- lanes have to be swapped.
>> +    type: boolean
> 
> What is not working with existing data-lanes property?
Hum, indeed. data-lanes could definitely be used here.

> 
> Plus, lanes are swapped per port, not for entire device, no?
I'm not sure to get what you mean here.
The use case I'm trying to address is:
pin AD10(USB1_DM) of the AM625 is routed to USB_DP pin of an USB connector.
And pin AE9(USB1_DP) of the AM625 is routed to USB_DM pin of an USB 
connector.
And using LANE_REVERSE bit of MMR_USB2SS_CFG_PHY_CONFIG swaps the DM/DP 
lines of the corresponding USB instance.

Regards,
Richard

> 
> Best regards,
> Krzysztof
> 


  reply	other threads:[~2025-09-09  9:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 16:20 [PATCH 0/2] ti,am62-usb: introduce ti,lane-reverse property Richard Genoud
2025-09-08 16:20 ` [PATCH 1/2] dt-bindings: usb/ti,am62-usb.yaml: Add " Richard Genoud
2025-09-09  7:32   ` Krzysztof Kozlowski
2025-09-09  9:11     ` Richard GENOUD [this message]
2025-09-14 14:55       ` Krzysztof Kozlowski
2025-09-18 15:41         ` Richard GENOUD
2025-09-19  4:31           ` Krzysztof Kozlowski
2025-09-08 16:20 ` [PATCH 2/2] usb: dwc3-am62: support " Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464f5995-be7d-41f6-8e95-7d724e2b5308@bootlin.com \
    --to=richard.genoud@bootlin.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=a-govindraju@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox