From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbcFUPrs (ORCPT ); Tue, 21 Jun 2016 11:47:48 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:63129 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbcFUPro (ORCPT ); Tue, 21 Jun 2016 11:47:44 -0400 From: Arnd Bergmann To: libc-alpha@sourceware.org Cc: Andreas Schwab , "Zhangjian (Bamvor)" , Yury Norov , catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, pinskia@gmail.com, broonie@kernel.org, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com, szabolcs.nagy@arm.com, klimov.linux@gmail.com, Nathan_Lynch@mentor.com, agraf@suse.de, Prasun.Kapoor@caviumnetworks.com, kilobyte@angband.pl, geert@linux-m68k.org, philipp.tomsich@theobroma-systems.com, manuel.montezelo@gmail.com, linyongting@huawei.com, maxim.kuvyrkov@linaro.org, davem@davemloft.net, Andrew Pinski Subject: Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Date: Tue, 21 Jun 2016 17:47:44 +0200 Message-ID: <4650742.YG7pOR48ul@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1466207668-10549-1-git-send-email-ynorov@caviumnetworks.com> <576915B0.5040706@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:TPrNaOM7xrbakPEgJDih5NMHycWTsjD8DwRA8Pv0CL6ecfoYw8E tIPmrhAteNO6vgy1rQ3ROYz/sGAlaj91KHquonl7nKzDEuDrjQsoErZI6JY/8ISejH0N4Yx f4JZ8o5s9ZSHucErsMp36+Fm7ImRguPjW+duPfPfwVHporyMdJEGgNEEeIDs2nPdNdoOcgg K28dcH6ki9P0A8oymdqfQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:vKXVUYGx7vc=:pMkNMS2/oI/nfhmD4t0hcK cWUMXBpuyLdD5+GrOHzBN8Q+D/qqmWE8M3HKwFzI+uoJRAZpn/J1ywofIEJPMf7MxWwt0xgU5 PW0hT6rfRcBLmn1AjTNoMY2b2s27Rzk5e3/ierpwcG9FTePGxjMp+rL9NT8qy3fLHuZFt+7YP kVhF6IEcqHZvLXHpiMRazEkMpwYu9nI5FkWA1zJfLYQilS3ie24OdzJGoPyBBUOKTbPazNYrH rA96neL6MXWbJe0JXgojceDxzxG0q+DcEG5IMs1vYcXM2osF5uwdNHUMCPE8u5Mz/j+Vg/AvX 9hvlqUj2vU9F2RciJqQGY0mcR61tE0vZkk8RrnNBUxqGfDY/MDElxHlONTwA6OOmMXZnr+99W y8yhkqSPX1QuSzw7q/lzIxdaFoRk3opiyOhbxHsFIFfSgp1K1dH5Z3i22OZ/2WgNQt51YQfse HX1hb0rTcqOO38MJEP6AJk4+cHQiQ2XWVZGlO5xHa8uO7OHkz+8yDUaVhElB2q5ios6cQCDEv XTFZpB+uEwU/vfyEKoS2gVemlDOZnJbpHxiEKRtJbT62JSgYL4EWeBKTGn9wsOEplYApZLcbW 3TyhzeIpRPF79t7+bGDM/7JivUth71ZbID8Uk5EjmWG9RjGpjzDslD3G67UDpbnXUlhRhlyIH ey9GQWHyJgUDuXbZLm1fwtBAoCZREmS8YWvAa0zQdfZ2N1Tb3Y3GqgyTVPS3IoZK9JBcMyw4m iip3SPZCScsPGyM1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 21, 2016 1:34:59 PM CEST Andreas Schwab wrote: > "Zhangjian (Bamvor)" writes: > > >> @@ -78,9 +79,9 @@ > >> > >> #ifdef CONFIG_COMPAT > >> #define TASK_SIZE_32 UL(0x100000000) > >> -#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \ > >> +#define TASK_SIZE (is_compat_task() ? \ > >> TASK_SIZE_32 : TASK_SIZE_64) > >> -#define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \ > >> +#define TASK_SIZE_OF(tsk) (is_compat_thread(tsk) ? \ > > It should be > > +#define TASK_SIZE_OF(tsk) (is_compat_thread(task_thread_info(tsk)) ? \ > > is_compat_thread takes "struct thread_info *thread" while TASK_SIZE_OF takes > > "struct task_struct *tsk"tsk. > > If that doesn't throw an error does that mean that TASK_SIZE_OF is > unused? I think that is correct. On some architectures, TASK_SIZE (which is used) is defined as TASK_SIZE_OF(current), but the definition above doesn't do that and there are no other users. Arnd