Re: something strange in libata-core.c for kernel 2.6.22-rc3

[Robert Hancock <hancockr@shaw.ca>]

l.genoni@oltrelinux.com wrote:
> 
> Mybe I am wrong, but if you are detecting 40-wire cable to set them to 
> DMA/33, why the check includes also 80-wire cables configuring them to 
> DMA/33 too?
> 
> With this patch my nvidia4 IDE controllers detects correctly and 
> configure correctly DMA/100 for my HD and DMA/33 for my DVD (the first 
> uses a 80-wire cable, the second a 40-wire cable).
> 
> Am I wrong somewhere?
> 
> --- libata-core.c.orig  2007-05-20 14:31:25.000000000 +0200
> +++ libata-core.c       2007-05-20 14:34:01.000000000 +0200
> @@ -3901,8 +3901,7 @@
>                 /* UDMA/44 or higher would be available */
>                 if((ap->cbl == ATA_CBL_PATA40) ||
>                     (ata_drive_40wire(dev->id) &&
> -                    (ap->cbl == ATA_CBL_PATA_UNK ||
> -                     ap->cbl == ATA_CBL_PATA80))) {
> +                    (ap->cbl == ATA_CBL_PATA_UNK))) {
>                         ata_dev_printk(dev, KERN_WARNING,
>                                  "limited to UDMA/33 due to 40-wire 
> cable\n");
>                         xfer_mask &= ~(0xF8 << ATA_SHIFT_UDMA);

It only does that for ATA_CBL_PATA80 if ata_drive_40wire returns true, 
which means that the drive is detecting a 40-wire cable on its side.

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/