From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758177AbXETRqo (ORCPT ); Sun, 20 May 2007 13:46:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756209AbXETRqh (ORCPT ); Sun, 20 May 2007 13:46:37 -0400 Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10]:10599 "EHLO pd3mo1so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755571AbXETRqh (ORCPT ); Sun, 20 May 2007 13:46:37 -0400 Date: Sun, 20 May 2007 11:45:03 -0600 From: Robert Hancock Subject: Re: sd_resume redundant? [was: [PATCH] libata: implement ata_wait_after_reset()] In-reply-to: To: Indan Zupancic , linux-kernel Cc: Tejun Heo Message-id: <4650891F.80301@shaw.ca> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit References: User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Indan Zupancic wrote: >>> Everything seems to work fine without sd_resume(), so why is it needed? >> Because not all disks spin up without being told to do so and like it or >> not spinning disks up on resume is the default behavior. As I wrote in >> the other reply, it would be worthwhile to make it configurable. > > Not even after they receive a read command? Ugh. ATA disks are supposed to spin up, yes. SCSI disks require a command to tell them to spin up if they're in the "stopped" state. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/