From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andi Kleen <ak@suse.de>, Andrey Borzenkov <arvidjaar@mail.ru>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix section mismatch warnings in mtrr
Date: Mon, 21 May 2007 14:52:39 +0100 [thread overview]
Message-ID: <4651A427.4010600@goop.org> (raw)
In-Reply-To: <20070521134828.GA1394@uranus.ravnborg.org>
Sam Ravnborg wrote:
> There was another patch that removed the __init marker to _fix_ section mismatch errors.
> I have lost the actual mail but I asked the submitter to send me a copy of
> the configuration so I could take a closer look.
> Obviously it was the wrong fix to remove the _init marker.
Hm, I think there were two overlapping patches to address the problem.
One removed the __init markers, and was a bit of a hack. Mine
restructured all the functions so that it was all done properly (ie,
init called init; cpuinit called cpuinit). Looks like both got applied.
J
next prev parent reply other threads:[~2007-05-21 13:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 10:43 2.6.22-rc2: section mismatch Andrey Borzenkov
2007-05-19 11:00 ` Michal Piotrowski
2007-05-19 11:25 ` Andrey Borzenkov
2007-05-19 13:30 ` Indan Zupancic
2007-05-19 13:27 ` Sam Ravnborg
2007-05-19 13:32 ` [PATCH] x86: fix section mismatch warnings in mtrr Sam Ravnborg
2007-05-19 13:55 ` Andi Kleen
2007-05-19 14:09 ` Sam Ravnborg
2007-05-21 13:39 ` Jeremy Fitzhardinge
2007-05-21 13:48 ` Sam Ravnborg
2007-05-21 13:50 ` Sam Ravnborg
2007-05-21 13:52 ` Jeremy Fitzhardinge [this message]
2007-05-21 15:11 ` Sam Ravnborg
2007-05-26 12:07 ` Indan Zupancic
2007-05-26 16:02 ` Andi Kleen
2007-05-27 9:05 ` Sam Ravnborg
2007-05-27 9:56 ` Andi Kleen
2007-05-27 17:57 ` Andrew Morton
2007-05-28 20:04 ` Sam Ravnborg
2007-05-27 11:39 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4651A427.4010600@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=arvidjaar@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox