From: Eric Sandeen <sandeen@redhat.com>
To: maneesh@in.ibm.com
Cc: Tejun Heo <htejun@gmail.com>, Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>,
Clemens Schwaighofer <cs@tequila.co.jp>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dipankar Sarma <dipankar@in.ibm.com>,
Chuck Ebbert <cebbert@redhat.com>
Subject: Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2
Date: Mon, 21 May 2007 11:02:59 -0500 [thread overview]
Message-ID: <4651C2B3.10905@redhat.com> (raw)
In-Reply-To: <20070521050101.GC9214@in.ibm.com>
Maneesh Soni wrote:
> Looks ok to me.. I have tested it it but unfortunately I couldn't
> recreate the race without the patch also. It would be helpful if
> people actually seeing the race, provide the test results.
>
> Greg, please merge this one once we have some test results.
I merged this back to RHEL4-era (2.6.9) kernels due to a report of this
problem on RHEL4. The tester could hit the sysfs_d_iput bug fairly
easily before, and has not seen it with this patch in place.
The other bug they were seeing even more often was the sysfs_readdir()
oops as we try to extract the inode number for regular sysfs files,
again due to transient vnodes. Is any fix for that problem being
considered for -stable? I had backported a simpler version of Tejun's
s_ino fix for the problem, without the ida complexity - and brought a
couple other small upstream fixes back to support that. If nothing has
yet been proposed for -stable, I can post that here.
Thanks,
-Eric
next prev parent reply other threads:[~2007-05-21 16:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 0:24 Oops and Panics in 2.6.21.1, 2.6.20.6 and 2.6.19.2 Clemens Schwaighofer
2007-05-16 1:52 ` Clemens Schwaighofer
2007-05-16 1:53 ` Andrew Morton
2007-05-16 2:02 ` Clemens Schwaighofer
2007-05-16 2:46 ` Clemens Schwaighofer
2007-05-16 3:18 ` Andrew Morton
2007-05-16 11:05 ` Tejun Heo
2007-05-16 15:29 ` Andrew Morton
2007-05-16 15:40 ` Tejun Heo
2007-05-16 16:06 ` Chuck Ebbert
2007-05-16 16:13 ` Andrew Morton
2007-05-16 18:31 ` [PATCH -stable] sysfs: disable reclamation by default Tejun Heo
2007-05-17 12:04 ` Greg KH
2007-05-17 17:39 ` Maneesh Soni
2007-05-17 17:49 ` Tejun Heo
2007-05-17 17:52 ` [PATCH 1/2] sysfs: fix condition check in sysfs_drop_dentry() Tejun Heo
2007-05-21 4:35 ` Maneesh Soni
2007-05-17 17:59 ` [PATCH 2/2] sysfs: fix race condition around sd->s_dentry Tejun Heo
2007-05-17 18:16 ` [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2 Tejun Heo
2007-05-21 5:01 ` Maneesh Soni
2007-05-21 16:02 ` Eric Sandeen [this message]
2007-05-21 16:15 ` Tejun Heo
2007-05-22 22:38 ` Greg KH
2007-05-23 8:21 ` Tejun Heo
2007-06-08 14:35 ` Tejun Heo
2007-06-09 6:49 ` Tejun Heo
2007-06-10 16:18 ` Greg KH
2007-05-21 4:39 ` [PATCH -stable] sysfs: disable reclamation by default Maneesh Soni
2007-05-17 18:54 ` Oops and Panics in 2.6.21.1, 2.6.20.6 and 2.6.19.2 Eric Sandeen
2007-06-29 2:51 ` Clemens Schwaighofer
2007-06-29 6:12 ` Satyam Sharma
2007-06-29 6:18 ` Clemens Schwaighofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4651C2B3.10905@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=cs@tequila.co.jp \
--cc=dipankar@in.ibm.com \
--cc=greg@kroah.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).