From: Tejun Heo <htejun@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Maneesh Soni <maneesh@in.ibm.com>,
stable@kernel.org
Subject: Re: [stable] [PATCH] - fix oops in sysfs_readdir
Date: Tue, 22 May 2007 03:11:33 +0200 [thread overview]
Message-ID: <46524345.5040505@gmail.com> (raw)
In-Reply-To: <20070521175445.adab3608.akpm@linux-foundation.org>
Andrew Morton wrote:
> Actually, someone (eg distros) looking at Tejun's changelog would still be
> struggling to answer the question "do I need this". The one thing it
> claims to fix is "duplicate inode numbers". But why is that a problem?
> What are the user-visible consequences of not merging the patch? Unobvious.
The oops part is explained in #2. sysfs_dirent->s_dentry can go away
anytime and the original code accesses it without any synchronization,
so it can end up dereferencing NULL or access already freed memory.
And, yeah, this is another place where reclaim-related oops occurs.
--
tejun
next prev parent reply other threads:[~2007-05-22 1:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 18:11 [stable] [PATCH] - fix oops in sysfs_readdir Eric Sandeen
2007-05-21 18:21 ` Chris Wright
2007-05-21 19:02 ` [stable] " Eric Sandeen
2007-05-21 22:39 ` Andrew Morton
2007-05-22 0:18 ` Eric Sandeen
2007-05-22 0:54 ` Andrew Morton
2007-05-22 1:11 ` Tejun Heo [this message]
2007-05-22 2:32 ` [stable] [PATCH] - store sysfs inode nrs in s_ino to avoid readdir oopses Eric Sandeen
2007-06-06 19:49 ` patch sysfs-store-sysfs-inode-nrs-in-s_ino-to-avoid-readdir-oopses.patch queued to -stable tree gregkh
2007-06-06 21:35 ` [stable] " Chris Wright
2007-06-06 21:36 ` Eric Sandeen
2007-06-06 22:05 ` Chris Wright
2007-06-06 22:30 ` Greg KH
2007-05-22 23:17 ` [stable] [PATCH] - fix oops in sysfs_readdir Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46524345.5040505@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=sandeen@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox