From: Jiri Slaby <jirislaby@gmail.com>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: use mutex instead of semaphore in RocketPort driver
Date: Tue, 22 May 2007 23:23:34 +0200 [thread overview]
Message-ID: <46535F56.1010009@gmail.com> (raw)
In-Reply-To: <46535AD3.9060904@simon.arlott.org.uk>
Simon Arlott napsal(a):
> On 22/05/07 21:06, Matthias Kaehlcke wrote:
>> would the following resolve the problem?
>>
>> if(mutex_lock_interruptible(&info->write_mtx)) return
>> -ERESTARTSYS
>>
>> thanks for your comments
>>
>
> No. At least one user of tty_operations/tty_driver's write function
> doesn't check the return value so it would never be retried, mutex_lock
> should be used instead.
Who? There are some drivers that returns ERESTARTSYS from write function.
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
prev parent reply other threads:[~2007-05-22 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705081903.l48J3lr1012622@hera.kernel.org>
2007-05-22 16:59 ` use mutex instead of semaphore in RocketPort driver Arjan van de Ven
2007-05-22 20:06 ` Matthias Kaehlcke
2007-05-22 21:04 ` Simon Arlott
2007-05-22 21:23 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46535F56.1010009@gmail.com \
--to=jirislaby@gmail.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.kaehlcke@gmail.com \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox