public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Greg KH <greg@kroah.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Kristian H?gsberg" <krh@bitplanet.net>
Subject: Re: Race free attributes in sysfs
Date: Wed, 23 May 2007 07:44:53 +0200	[thread overview]
Message-ID: <4653D4D5.5030504@drzeus.cx> (raw)
In-Reply-To: <20070523042418.GB27329@kroah.com>

Greg KH wrote:
> If you can come up with a wrapper that will work, please let me know and
> I'll be glad to add it.  Right now, it's pretty darn simple to do this
> (look at the USB and PCI core code for examples if you need it.)
>
>   

I guess we have different views on "simple" :)

I had a look at the usb code, which is why I think the current method is
a bit indirect. Right now I instead copied the function that adds the
device attributes given in the bus_type structure. Couldn't that be used
in a more general manner to get device attribute groups?

> Anyway, groups are what you want and need, please use them and then you
> don't have to worry about triggering an event later after you have
> created your files on your own.
>   

I take it I can supply an array of groups somewhere?

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org


      reply	other threads:[~2007-05-23  5:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20 11:01 Race free attributes in sysfs Pierre Ossman
2007-05-21  3:12 ` Dmitry Torokhov
2007-05-21  7:47   ` Pierre Ossman
2007-05-22 21:24   ` Mark Lord
2007-05-23  2:43     ` Dmitry Torokhov
2007-05-23  4:21       ` Greg KH
2007-05-23 13:27         ` Mark Lord
2007-05-23 15:14           ` Greg KH
2007-05-26 16:12             ` Bill Davidsen
2007-05-27  8:57               ` Greg KH
2007-05-21 17:50 ` Kay Sievers
2007-05-21 18:43   ` Pierre Ossman
2007-05-21 19:28     ` Kay Sievers
2007-05-22  8:38       ` Cornelia Huck
2007-05-23  4:25         ` Greg KH
2007-05-22 15:40       ` Pierre Ossman
2007-05-22 15:58         ` Kristian Høgsberg
2007-05-22 21:25         ` Mark Lord
2007-05-23  4:24         ` Greg KH
2007-05-23  5:44           ` Pierre Ossman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4653D4D5.5030504@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=krh@bitplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox