From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ingo Molnar <mingo@elte.hu>, Anant Nitya <kernel@prachanda.info>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: bad networking related lag in v2.6.22-rc2
Date: Wed, 23 May 2007 13:33:48 +0200 [thread overview]
Message-ID: <4654269C.4040809@trash.net> (raw)
In-Reply-To: <20070523112559.GA24604@gondor.apana.org.au>
Herbert Xu wrote:
> On Wed, May 23, 2007 at 12:56:04PM +0200, Patrick McHardy wrote:
>
>>Looking at the recent changes to __qdisc_run, this indeed seems
>>to be the case, when the qdisc is throttled and has packets queued
>>we return a value != 0, causing __qdisc_run to loop until all
>>packets have been sent, which may be a long time.
>
>
> Good catch! I was obviously half awake at the time :)
>
> We could also fix it this way:
Yes, that looks better, thanks.
next prev parent reply other threads:[~2007-05-23 11:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 17:45 [patch] CFS scheduler, -v13 Ingo Molnar
2007-05-17 21:47 ` Anant Nitya
2007-05-18 10:26 ` Ingo Molnar
2007-05-18 16:13 ` Anant Nitya
2007-05-19 21:16 ` Anant Nitya
2007-05-20 6:38 ` Ingo Molnar
2007-05-21 7:58 ` bad networking related lag in v2.6.22-rc2 Ingo Molnar
2007-05-21 8:03 ` Ingo Molnar
2007-05-21 8:05 ` Ingo Molnar
2007-05-21 8:12 ` Ingo Molnar
2007-05-21 8:29 ` David Miller
2007-05-21 10:09 ` Ingo Molnar
2007-05-21 10:14 ` Anant Nitya
2007-05-21 10:20 ` Ingo Molnar
2007-05-22 6:20 ` Anant Nitya
2007-05-21 19:40 ` Anant Nitya
2007-05-21 20:46 ` Ingo Molnar
2007-05-21 21:02 ` Patrick McHardy
2007-05-21 21:30 ` Patrick McHardy
2007-05-22 6:17 ` Anant Nitya
2007-05-22 6:22 ` Ingo Molnar
2007-05-23 5:40 ` Anant Nitya
2007-05-23 6:30 ` Ingo Molnar
2007-05-23 10:56 ` Patrick McHardy
2007-05-23 11:05 ` Ingo Molnar
2007-05-23 11:25 ` Herbert Xu
2007-05-23 11:33 ` Patrick McHardy [this message]
2007-05-23 15:00 ` Linus Torvalds
2007-05-23 17:16 ` Patrick McHardy
2007-05-23 11:40 ` Ingo Molnar
2007-05-23 21:30 ` David Miller
2007-05-24 5:41 ` Patrick McHardy
2007-05-24 6:40 ` David Miller
2007-05-24 7:12 ` Anant Nitya
2007-05-22 6:23 ` Ingo Molnar
2007-05-22 6:24 ` Ingo Molnar
2007-05-22 9:17 ` Patrick McHardy
2007-05-22 12:47 ` Anant Nitya
2007-05-21 8:25 ` David Miller
2007-05-21 8:28 ` Ingo Molnar
2007-05-21 8:30 ` David Miller
2007-05-21 15:57 ` [patch] CFS scheduler, -v13 Linus Torvalds
2007-05-22 22:06 ` Bill Davidsen
2007-05-23 5:45 ` Anant Nitya
2007-05-18 15:20 ` Michael Lothian
2007-05-18 15:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4654269C.4040809@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@prachanda.info \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).