public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Rob Landley <rob@landley.net>, linux-kernel@vger.kernel.org
Subject: Re: Status of CONFIG_FORCED_INLINING?
Date: Wed, 23 May 2007 14:31:33 -0700	[thread overview]
Message-ID: <4654B2B5.4080207@linux.intel.com> (raw)
In-Reply-To: <20070523212237.GH2098@stusta.de>

Adrian Bunk wrote:
> 
> What about performance reasons?
> We habe "inline" code in header files that heavily relies on being 
> nearly completely optimized away after being inlined.

fair

> Especially with -Os it could even sound logical for a compiler to never 
> inline a non-forced "inline"'d three line function with 2 callers.

but you said "I Care about size more than performance". Your argument 
is thus absolutely incorrect.

> The rules are simple:
> - every static function in a header file must be __always_inline

wrong.

> 
> Your suggestion is possible, but please also send a patch that turns 
> every "inline" in header files into __always_inline...

this is 1) insane and 2) if inlines in headers are so big gcc decides 
to not inline them.. they're too big and don't belong in the header.

  parent reply	other threads:[~2007-05-23 21:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 19:10 Status of CONFIG_FORCED_INLINING? Rob Landley
2007-05-23 19:42 ` Arjan van de Ven
2007-05-23 21:22   ` Adrian Bunk
2007-05-23 21:28     ` Roland Dreier
2007-05-24 12:38       ` Robert P. J. Day
2007-05-24 16:55         ` Rob Landley
2007-05-24 17:10       ` Adrian Bunk
2007-05-24 17:14         ` Roland Dreier
2007-05-24 17:47           ` Rob Landley
2007-05-24 17:47             ` Arjan van de Ven
2007-05-24 18:14               ` Rob Landley
2007-05-24 17:55             ` Roland Dreier
2007-05-24 18:07               ` Adrian Bunk
2007-05-24 18:32                 ` Roland Dreier
2007-05-24 22:41                   ` Adrian Bunk
2007-05-24 17:57           ` Adrian Bunk
2007-05-23 21:31     ` Arjan van de Ven [this message]
2007-05-24 17:12       ` Adrian Bunk
2007-05-24 16:29     ` Jan Engelhardt
2007-05-24 17:14       ` Adrian Bunk
2007-05-24 17:17         ` Arjan van de Ven
2007-05-24 17:40       ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4654B2B5.4080207@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox