From: Peter Williams <pwil3058@bigpond.net.au>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
colpatch@us.ibm.com, Nick Piggin <nickpiggin@yahoo.com.au>,
Con Kolivas <kernel@kolivas.org>,
Christoph Lameter <clameter@sgi.com>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] CFS scheduler, -v12
Date: Fri, 25 May 2007 09:23:19 +1000 [thread overview]
Message-ID: <46561E67.3030207@bigpond.net.au> (raw)
In-Reply-To: <20070524164538.GA13301@linux-os.sc.intel.com>
Siddha, Suresh B wrote:
> On Thu, May 24, 2007 at 12:43:58AM -0700, Peter Williams wrote:
>> Peter Williams wrote:
>>> The relevant code, find_busiest_group() and find_busiest_queue(), has a
>>> lot of code that is ifdefed by CONFIG_SCHED_MC and CONFIG_SCHED_SMT and,
>>> as these macros were defined in the kernels I was testing with, I built
>>> a kernel with these macros undefined and reran my tests. The
>>> problems/anomalies were not present in 10 consecutive tests on this new
>>> kernel. Even better on the few occasions that a 3/1 split did occur it
>>> was quickly corrected to 2/2 and top was reporting approx 49% of CPU for
>>> all spinners throughout each of the ten tests.
>>>
>>> So all that is required now is an analysis of the code inside the ifdefs
>>> to see why it is causing a problem.
>>
>> Further testing indicates that CONFIG_SCHED_MC is not implicated and
>> it's CONFIG_SCHED_SMT that's causing the problem. This rules out the
>> code in find_busiest_group() as it is common to both macros.
>>
>> I think this makes the scheduling domain parameter values the most
>> likely cause of the problem. I'm not very familiar with this code so
>> I've added those who've modified this code in the last year or
>> so to the
>> address of this e-mail.
>
> What platform is this? I remember you mentioned its a 2 cpu box. Is it
> dual core or dual package or one with HT?
It's a single CPU HT box i.e. 2 virtual CPUs. "cat /proc/cpuinfo" produces:
processor : 0
vendor_id : GenuineIntel
cpu family : 15
model : 3
model name : Intel(R) Pentium(R) 4 CPU 3.20GHz
stepping : 4
cpu MHz : 3201.145
cache size : 1024 KB
physical id : 0
siblings : 2
core id : 0
cpu cores : 1
fdiv_bug : no
hlt_bug : no
f00f_bug : no
coma_bug : no
fpu : yes
fpu_exception : yes
cpuid level : 5
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe
constant_tsc pni monitor ds_cpl cid xtpr
bogomips : 6403.97
clflush size : 64
processor : 1
vendor_id : GenuineIntel
cpu family : 15
model : 3
model name : Intel(R) Pentium(R) 4 CPU 3.20GHz
stepping : 4
cpu MHz : 3201.145
cache size : 1024 KB
physical id : 0
siblings : 2
core id : 0
cpu cores : 1
fdiv_bug : no
hlt_bug : no
f00f_bug : no
coma_bug : no
fpu : yes
fpu_exception : yes
cpuid level : 5
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe
constant_tsc pni monitor ds_cpl cid xtpr
bogomips : 6400.92
clflush size : 64
Peter
--
Peter Williams pwil3058@bigpond.net.au
"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
next prev parent reply other threads:[~2007-05-24 23:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-13 15:38 [patch] CFS scheduler, -v12 Ingo Molnar
2007-05-16 2:04 ` Peter Williams
2007-05-16 8:08 ` Ingo Molnar
2007-05-16 23:42 ` Peter Williams
[not found] ` <20070516063625.GA9058@elte.hu>
2007-05-17 23:45 ` Peter Williams
[not found] ` <20070518071325.GB28702@elte.hu>
2007-05-18 13:11 ` Peter Williams
2007-05-18 13:26 ` Peter Williams
2007-05-19 13:27 ` Dmitry Adamushko
2007-05-20 1:41 ` Peter Williams
2007-05-21 8:29 ` William Lee Irwin III
2007-05-21 8:57 ` Ingo Molnar
2007-05-21 12:08 ` William Lee Irwin III
2007-05-22 16:48 ` Chris Friesen
2007-05-22 20:15 ` Ingo Molnar
2007-05-22 20:49 ` Chris Friesen
2007-05-21 15:25 ` Dmitry Adamushko
2007-05-21 23:51 ` Peter Williams
2007-05-22 4:47 ` Peter Williams
2007-05-22 12:03 ` Peter Williams
2007-05-24 7:43 ` Peter Williams
2007-05-24 16:45 ` Siddha, Suresh B
2007-05-24 23:23 ` Peter Williams [this message]
2007-05-29 20:45 ` Siddha, Suresh B
2007-05-29 23:54 ` Peter Williams
2007-05-30 0:50 ` Siddha, Suresh B
2007-05-30 2:18 ` Peter Williams
2007-05-30 4:42 ` Siddha, Suresh B
2007-05-30 6:28 ` Peter Williams
2007-05-31 1:49 ` Peter Williams
2007-05-22 11:52 ` Dmitry Adamushko
2007-05-23 0:10 ` Peter Williams
2007-05-18 0:18 ` Bill Huey
2007-05-18 1:01 ` Bill Huey
2007-05-18 4:13 ` William Lee Irwin III
2007-05-18 7:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46561E67.3030207@bigpond.net.au \
--to=pwil3058@bigpond.net.au \
--cc=clameter@sgi.com \
--cc=colpatch@us.ibm.com \
--cc=dmitry.adamushko@gmail.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox