From: Jeff Garzik <jeff@garzik.org>
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, htejun@gmail.com,
"Randy.Dunlap" <rdunlap@xenotime.net>
Subject: Re: [patch 1/7] libata: check for AN support
Date: Thu, 24 May 2007 23:15:56 -0400 [thread overview]
Message-ID: <465654EC.9080805@garzik.org> (raw)
In-Reply-To: <20070510100215.94c3a2ea.kristen.c.accardi@intel.com>
Kristen Carlson Accardi wrote:
> Check to see if an ATAPI device supports Asynchronous Notification.
> If so, enable it.
>
> Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> ---
> Andrew, I cleaned up the function header to properly comply with kernel
> doc requirements. Other than that, this patch is the same.
I would ask for a simple revision: update ata_dev_set_AN() such that it
takes a second argument 'enable'. This boolean indicates to the
function whether SETFEATURES_SATA_ENABLE or SETFEATURES_SATA_DISABLE
should be passed to the device.
Otherwise than that, it's ready to merge I would say.
next prev parent reply other threads:[~2007-05-25 3:16 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070510072247.063476979@intel.com>
2007-05-09 23:38 ` [patch 1/7] libata: check for AN support Kristen Carlson Accardi
2007-05-10 5:09 ` Andrew Morton
2007-05-10 5:14 ` Jeff Garzik
2007-05-10 5:25 ` Andrew Morton
2007-05-10 15:19 ` Randy Dunlap
2007-05-10 17:02 ` Kristen Carlson Accardi
2007-05-25 3:15 ` Jeff Garzik [this message]
2007-06-11 20:20 ` Kristen Carlson Accardi
2007-05-09 23:38 ` [patch 2/7] genhd: expose AN to user space Kristen Carlson Accardi
2007-05-09 23:38 ` [patch 3/7] scsi: " Kristen Carlson Accardi
2007-05-09 23:38 ` [patch 4/7] libata: " Kristen Carlson Accardi
2007-05-09 23:38 ` [patch 5/7] genhd: send async notification on media change Kristen Carlson Accardi
2007-05-22 21:12 ` Andrew Morton
2007-05-23 16:31 ` Kristen Carlson Accardi
2007-05-23 17:03 ` James Bottomley
2007-05-23 18:26 ` Kristen Carlson Accardi
2007-05-23 18:51 ` James Bottomley
2007-05-23 19:40 ` Kristen Carlson Accardi
2007-05-09 23:38 ` [patch 6/7] SCSI: save disk in scsi_device Kristen Carlson Accardi
2007-05-09 23:38 ` [patch 7/7] libata: send event when AN received Kristen Carlson Accardi
[not found] <20070424074856.005152262@intel.com>
2007-04-23 23:59 ` [patch 1/7] libata: check for AN support Kristen Carlson Accardi
2007-04-24 8:03 ` Tejun Heo
2007-04-24 15:54 ` Kristen Carlson Accardi
2007-04-24 8:07 ` Alan Cox
2007-04-24 10:23 ` Olivier Galibert
2007-04-24 15:49 ` Kristen Carlson Accardi
2007-04-24 18:05 ` Olivier Galibert
2007-04-24 18:29 ` Kristen Carlson Accardi
2007-04-24 20:53 ` Kristen Carlson Accardi
2007-04-25 0:49 ` Olivier Galibert
2007-04-25 17:55 ` Kristen Carlson Accardi
2007-04-25 18:40 ` Kristen Carlson Accardi
2007-04-25 19:16 ` Matt Sealey
2007-04-25 20:34 ` Kristen Carlson Accardi
2007-04-25 20:59 ` Matt Sealey
2007-04-25 20:40 ` Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465654EC.9080805@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).