From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: randy.dunlap@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] [condingstyle] Add chapter on tests
Date: Fri, 25 May 2007 10:40:41 -0700 [thread overview]
Message-ID: <46571F99.1050307@intel.com> (raw)
In-Reply-To: <46571E08.1050509@s5r6.in-berlin.de>
Stefan Richter wrote:
> Auke Kok wrote:
>> +If you give your variables and pointers good names, there is never a need
>> +to compare the value stored in that variable to NULL or true/false, so
>> +omit all that and keep it short.
>
> I agree with this in principle. But do we have to standardize it?
yes, I think so. Not only does it remove useless fluff but it forces you to pick
your function and variable names decently. It really doesn't hurt to mention it
especially when you see how many drivers have copied bad style over without
knowing better. Now we can refer them to the CodingStyle doc right away.
Auke
next prev parent reply other threads:[~2007-05-25 17:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 17:25 [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs Auke Kok
2007-05-25 17:25 ` [PATCH 2/2] [condingstyle] Add chapter on tests Auke Kok
2007-05-25 17:34 ` Stefan Richter
2007-05-25 17:40 ` Kok, Auke [this message]
2007-05-26 19:27 ` Jan Engelhardt
2007-05-26 20:13 ` [PATCH] " Jan Engelhardt
2007-05-26 22:35 ` Scott Preece
2007-05-27 14:37 ` Stefan Richter
2007-05-27 15:02 ` Jan Engelhardt
2007-05-27 15:23 ` Stefan Richter
2007-05-27 15:52 ` Jan Engelhardt
2007-05-27 21:01 ` Guennadi Liakhovetski
2007-05-27 18:04 ` [PATCH 2/2] " Kok, Auke
2007-05-27 20:17 ` Pekka Enberg
2007-05-27 16:08 ` Jesper Juhl
2007-05-25 17:32 ` [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs Stefan Richter
2007-05-25 19:43 ` H. Peter Anvin
2007-05-25 20:29 ` Kok, Auke
2007-05-25 21:26 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46571F99.1050307@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox