From: Julian Sikorski <belegdol@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Nigel Cunningham <nigel@nigel.suspend2.net>,
Randy Dunlap <rdunlap@xenotime.net>,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Richard Hughes <hughsient@gmail.com>,
Julian Sikorski <belegdol@gmail.com>, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH} x86_64 PM_TRACE support.
Date: Sun, 27 May 2007 22:10:32 +0100 [thread overview]
Message-ID: <4659F3C8.8080606@gmail.gom> (raw)
In-Reply-To: <20070527203955.GE3989@ucw.cz>
Pavel Machek pisze:
> Hi!
>
>> As promised I took another look at the patch and at what Randy had
>> prepared to fix the IA64 compilation error. I did some more work on it,
>> and believe that the following is the tidiest correct solution I can
>> come up with. It differs from the version that caused the compilation
>> error primarily in that:
>>
>> * the #include <asm/resume-trace.h> is inside the #ifdef
>> CONFIG_PM_TRACE.
>> * now-unnecessary protection for multiple #includes and ifdef testing of
>> CONFIG_PM_TRACE in the asm code were removed.
>> * do-nothing definitions for !PM_TRACE restored to
>> include/linux/resume-trace.h.
>>
>> We're therefore depending upon kernel/power/Kconfig having the right
>> depends condition. As far as I can see, IA64 doesn't define CONFIG_X86.
>> Is that correct, or do we need to have (X86 && !IA64)?
>
> ia64? did you mean x86-64?
>
> Otherwise looks ok to me.
>
IIRC enabling pm_trace on x86_64 was breaking compilation on ia64, so I
think Nigel meant the latter.
next prev parent reply other threads:[~2007-05-27 21:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 6:32 [PATCH} x86_64 PM_TRACE support Nigel Cunningham
2007-05-27 20:39 ` Pavel Machek
2007-05-27 21:10 ` Julian Sikorski [this message]
2007-05-27 21:54 ` Nigel Cunningham
2007-05-27 21:53 ` Randy Dunlap
2007-05-31 0:01 ` Dave Jones
2007-05-31 0:09 ` Randy Dunlap
2007-05-31 7:43 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4659F3C8.8080606@gmail.gom \
--to=belegdol@gmail.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=hughsient@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox