Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers

Nick Piggin
2007-05-29T05:14:55Z

Eric W. Biederman wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> writes:

>> However we
>>could still set_page_dirty of a block device page without buffers
>>via an mmap.
>
>
> After the page is made dirty via mmap we have:
> sys_write -> ... -> block_prepare_write -> ... -> create_empty_buffers.

Yep, that's what I mean.

> I suspect that is a pretty rare case but it does indeed seem to exist
> as a problem.

I think so too. But either we have some misunderstanding of the
codepaths involved, or the author of the comments there didn't
consider this case, so...

--
SUSE Labs, Novell Inc.