From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker
Date: Mon, 28 May 2007 13:10:22 +0100 [thread overview]
Message-ID: <465AC6AE.1060401@shadowen.org> (raw)
In-Reply-To: <20070527171817.4ce9d40d.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
>
>> +#gotos aren't indented
>> + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
>> + print "Gotos should not be indented\n";
>> + print "$herecurr";
>> + $clean = 0;
>> + }
>
> This should be "labels". Plus a lot of people do indent the labels by
> a single space to avoid confusing `diff -p', which seems a reasonable
> thing to not complain about.
Yep makes sense. Done.
-apw
next prev parent reply other threads:[~2007-05-28 12:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 17:11 [PATCH] add a trivial patch style checker Andy Whitcroft
2007-05-27 17:10 ` Randy Dunlap
2007-05-28 10:48 ` Andy Whitcroft
2007-05-29 15:00 ` Joel Schopp
2007-05-27 17:49 ` Andreas Schwab
2007-05-27 21:49 ` Dave Jones
2007-05-28 0:18 ` Andrew Morton
2007-05-28 12:10 ` Andy Whitcroft [this message]
2007-05-28 9:13 ` Sam Ravnborg
2007-05-28 9:45 ` Jan Engelhardt
2007-05-29 9:01 ` Andy Whitcroft
2007-05-29 16:12 ` Joel Schopp
2007-05-29 16:20 ` Julio M. Merino Vidal
2007-05-29 20:00 ` Jan Engelhardt
2007-05-29 1:51 ` Qi Yong
2007-05-29 2:23 ` Andi Kleen
2007-05-29 9:05 ` Andy Whitcroft
2007-05-29 20:22 ` Jan Engelhardt
2007-05-29 22:36 ` Randy Dunlap
2007-05-30 8:34 ` Jan Engelhardt
2007-05-30 15:33 ` Randy Dunlap
2007-05-30 16:04 ` Jan Engelhardt
2007-05-31 12:07 ` [PATCH] add a trivial patch style checker II Andi Kleen
2007-05-31 19:59 ` Dave Jones
2007-06-01 14:18 ` Andy Whitcroft
2007-05-29 11:53 ` [PATCH] add a trivial patch style checker Heiko Carstens
2007-05-29 13:19 ` Andi Kleen
2007-05-29 14:22 ` Heiko Carstens
2007-05-29 14:58 ` Andi Kleen
2007-05-29 16:43 ` Heiko Carstens
2007-05-29 23:21 ` Andi Kleen
2007-05-29 18:55 ` Andy Whitcroft
2007-05-29 21:07 ` [PATCH] add a trivial patch style checker v2 Andy Whitcroft
2007-05-29 22:42 ` Joel Schopp
2007-06-06 12:40 ` Geert Uytterhoeven
2007-06-06 15:04 ` Dave Jones
2007-06-06 18:35 ` Andy Whitcroft
2007-05-31 19:26 ` [PATCH] add a trivial patch style checker Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465AC6AE.1060401@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox