* [PATCH] pata_sis: FIFO whack
@ 2007-05-25 19:50 Alan Cox
2007-05-28 22:01 ` Jeff Garzik
2007-07-11 1:14 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Alan Cox @ 2007-05-25 19:50 UTC (permalink / raw)
To: jeff, linux-kernel
If you are using a SiS controller and the BIOS didn't set it up then the
FIFO may be left active when we try and set up the CD. Not convinced this
matters but I'd prefer to be safe
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc2-mm1/drivers/ata/pata_sis.c linux-2.6.22-rc2-mm1/drivers/ata/pata_sis.c
--- linux.vanilla-2.6.22-rc2-mm1/drivers/ata/pata_sis.c 2007-05-25 17:39:06.000000000 +0100
+++ linux-2.6.22-rc2-mm1/drivers/ata/pata_sis.c 2007-05-25 18:22:21.000000000 +0100
@@ -149,6 +149,9 @@
if (!pci_test_config_bits(pdev, &sis_enable_bits[ap->port_no]))
return -ENOENT;
+ /* Clear the FIFO settings. We can't enable the FIFO until
+ we know we are poking at a disk */
+ pci_write_config_byte(pdev, 0x4B, 0);
return ata_std_prereset(ap, deadline);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pata_sis: FIFO whack
2007-05-25 19:50 [PATCH] pata_sis: FIFO whack Alan Cox
@ 2007-05-28 22:01 ` Jeff Garzik
2007-07-11 1:14 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-05-28 22:01 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel, IDE/ATA development list
Alan Cox wrote:
> If you are using a SiS controller and the BIOS didn't set it up then the
> FIFO may be left active when we try and set up the CD. Not convinced this
> matters but I'd prefer to be safe
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc2-mm1/drivers/ata/pata_sis.c linux-2.6.22-rc2-mm1/drivers/ata/pata_sis.c
> --- linux.vanilla-2.6.22-rc2-mm1/drivers/ata/pata_sis.c 2007-05-25 17:39:06.000000000 +0100
> +++ linux-2.6.22-rc2-mm1/drivers/ata/pata_sis.c 2007-05-25 18:22:21.000000000 +0100
> @@ -149,6 +149,9 @@
> if (!pci_test_config_bits(pdev, &sis_enable_bits[ap->port_no]))
> return -ENOENT;
>
> + /* Clear the FIFO settings. We can't enable the FIFO until
> + we know we are poking at a disk */
> + pci_write_config_byte(pdev, 0x4B, 0);
> return ata_std_prereset(ap, deadline);
Should I queue this into #upstream (2.6.23) or #upstream-fixes
(2.6.22-rc) branch?
I lean towards #upstream since it is so late in the 2.6.22-rc cycle,
because of your comment "Not convinced this matters".
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pata_sis: FIFO whack
2007-05-25 19:50 [PATCH] pata_sis: FIFO whack Alan Cox
2007-05-28 22:01 ` Jeff Garzik
@ 2007-07-11 1:14 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-07-11 1:14 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel
Alan Cox wrote:
> If you are using a SiS controller and the BIOS didn't set it up then the
> FIFO may be left active when we try and set up the CD. Not convinced this
> matters but I'd prefer to be safe
>
> Signed-off-by: Alan Cox <alan@redhat.com>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-11 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-25 19:50 [PATCH] pata_sis: FIFO whack Alan Cox
2007-05-28 22:01 ` Jeff Garzik
2007-07-11 1:14 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox