public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joel Schopp <jschopp@austin.ibm.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Andrew Morton <akpm@osdl.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker
Date: Tue, 29 May 2007 11:12:44 -0500	[thread overview]
Message-ID: <465C50FC.8050604@austin.ibm.com> (raw)
In-Reply-To: <465BEBE5.5070008@shadowen.org>

>>> +		if(!($prevline=~/\/\*\*/) && length($lineforcounting) > 80){
>> Actually, I think this should be "> 79" (after stripping a .diff's
>> control column), since the cursor may move to the 81th column when
>> editing an 80-col line - which is what we want to avoid, no?
> 
> 80 tends to work for me because of that "if on 80 then don't wrap until
> there is another character" behaviour of most terminals.  Anyone else
> with a firm opinion.

I think 80 is good.  What the specific number is does not matter much, we all have 
screens wider than 80 characters.  The point is just to have a number that prevents 
really long lines and prevents people from indenting too many levels past our minds 
ability to keep up.  We've already all been coding to 80, and it happens to be a nice 
round number we can all remember and love.  The only reason I see to select 79 is 
that prime numbers are generally cooler than other numbers.

-Joel


  reply	other threads:[~2007-05-29 16:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-27 17:11 [PATCH] add a trivial patch style checker Andy Whitcroft
2007-05-27 17:10 ` Randy Dunlap
2007-05-28 10:48   ` Andy Whitcroft
2007-05-29 15:00   ` Joel Schopp
2007-05-27 17:49 ` Andreas Schwab
2007-05-27 21:49 ` Dave Jones
2007-05-28  0:18 ` Andrew Morton
2007-05-28 12:10   ` Andy Whitcroft
2007-05-28  9:13 ` Sam Ravnborg
2007-05-28  9:45 ` Jan Engelhardt
2007-05-29  9:01   ` Andy Whitcroft
2007-05-29 16:12     ` Joel Schopp [this message]
2007-05-29 16:20       ` Julio M. Merino Vidal
2007-05-29 20:00     ` Jan Engelhardt
2007-05-29  1:51 ` Qi Yong
2007-05-29  2:23 ` Andi Kleen
2007-05-29  9:05   ` Andy Whitcroft
2007-05-29 20:22     ` Jan Engelhardt
2007-05-29 22:36       ` Randy Dunlap
2007-05-30  8:34         ` Jan Engelhardt
2007-05-30 15:33           ` Randy Dunlap
2007-05-30 16:04             ` Jan Engelhardt
2007-05-31 12:07     ` [PATCH] add a trivial patch style checker II Andi Kleen
2007-05-31 19:59       ` Dave Jones
2007-06-01 14:18         ` Andy Whitcroft
2007-05-29 11:53   ` [PATCH] add a trivial patch style checker Heiko Carstens
2007-05-29 13:19     ` Andi Kleen
2007-05-29 14:22       ` Heiko Carstens
2007-05-29 14:58         ` Andi Kleen
2007-05-29 16:43           ` Heiko Carstens
2007-05-29 23:21             ` Andi Kleen
2007-05-29 18:55   ` Andy Whitcroft
2007-05-29 21:07 ` [PATCH] add a trivial patch style checker v2 Andy Whitcroft
2007-05-29 22:42   ` Joel Schopp
2007-06-06 12:40   ` Geert Uytterhoeven
2007-06-06 15:04     ` Dave Jones
2007-06-06 18:35     ` Andy Whitcroft
2007-05-31 19:26 ` [PATCH] add a trivial patch style checker Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465C50FC.8050604@austin.ibm.com \
    --to=jschopp@austin.ibm.com \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox